You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by sedat ciftci <se...@yahoo.com> on 2007/05/05 12:37:42 UTC

problem in Roller 3.1 optional themes

In roller 3.1 oprional themes, $url.resource(String
file)  macro is used to get the resources
(images,styles etc) of a theme. But this will not
work, and the appearance of theme is not seen
correctly. I change the usage of $url.resource(String
file) with $url.themeResource(String theme, String
file) macro and the themes are working correctly now. 
  Sedat

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

Re: problem in Roller 3.1 optional themes

Posted by sedat ciftci <se...@yahoo.com>.
I see that if a theme uses the $url.resource() macro,
the user has to customize this theme to see the
resources (images, etc.) it uses; otherwise the
resources are not seen. This problem can be solved by
copying the resources of a theme to the user directory
whether user customizes it or not.
  Sedat
 
--- sedat ciftci <se...@yahoo.com> wrote:

> 
> --- Dave <sn...@gmail.com> wrote:
> 
> > On 5/7/07, Allen Gilliland
> <al...@sun.com>
> > wrote:
> > > Richard Jones wrote:
> > > > Correct me if I'm wrong but I thought that now
> > in 3.1 we were using
> > > > $url.resource() as opposed to
> > $url.themeResource()...  because now the
> > > > resources are copied across when you customize
> a
> > theme so instead of
> > > > using the original theme resource, you would
> use
> > your own copy.
> 
> If user do not customize a theme, then what happens?
> Which resources are used? The problem may arise from
> that point.
>   Sedat
> 
> > > >
> > > > Just checked 'sotto' & 'brushmetal' theme
> (both
> > shipped with roller)
> > > > and they use $url.resource() and not
> > $url.themeResource().
> > > >
> > > > Is this right?
> > >
> > > yes, that is correct and it's *imperative* that
> > you use $url.resource()
> > > this way to prevent pointers to shared
> resources.
> > 
> > So what is the problem? Is it simply that the
> themes
> > need to be
> > updated for the new encapsulated theme support?
> > 
> > - Dave
> > 
> > 
> > 
> > >
> > > -- Allen
> > >
> > >
> > > >
> > > > - Richard
> > > >
> > > >
> > > >
> > > > On 07/05/07, Dave <sn...@gmail.com> wrote:
> > > >> On 5/5/07, sedat ciftci
> <se...@yahoo.com>
> > wrote:
> > > >> > In roller 3.1 oprional themes,
> > $url.resource(String
> > > >> > file)  macro is used to get the resources
> > > >> > (images,styles etc) of a theme. But this
> will
> > not
> > > >> > work, and the appearance of theme is not
> seen
> > > >> > correctly. I change the usage of
> > $url.resource(String
> > > >> > file) with $url.themeResource(String theme,
> > String
> > > >> > file) macro and the themes are working
> > correctly now.
> > > >> >   Sedat
> > > >>
> > > >> Thanks for pointing that out. I filed a bug
> so
> > that we don't forget to
> > > >> fix this:
> > > >>
> >
>
http://opensource.atlassian.com/projects/roller/browse/ROL-1406
> > > >>
> > > >> - Dave
> > > >>
> > > >>
> > > >> >
> > > >> >
> > __________________________________________________
> > > >> > Do You Yahoo!?
> > > >> > Tired of spam?  Yahoo! Mail has the best
> spam
> > protection around
> > > >> > http://mail.yahoo.com
> > > >> >
> > > >>
> > > >>
> > >
> > 
> 
> 
> 
>  
>
____________________________________________________________________________________
> Bored stiff? Loosen up... 
> Download and play hundreds of games for free on
> Yahoo! Games.
> http://games.yahoo.com/games/front
> 



 
____________________________________________________________________________________
Bored stiff? Loosen up... 
Download and play hundreds of games for free on Yahoo! Games.
http://games.yahoo.com/games/front

Re: problem in Roller 3.1 optional themes

Posted by sedat ciftci <se...@yahoo.com>.
--- Dave <sn...@gmail.com> wrote:

> On 5/7/07, Allen Gilliland <al...@sun.com>
> wrote:
> > Richard Jones wrote:
> > > Correct me if I'm wrong but I thought that now
> in 3.1 we were using
> > > $url.resource() as opposed to
> $url.themeResource()...  because now the
> > > resources are copied across when you customize a
> theme so instead of
> > > using the original theme resource, you would use
> your own copy.

If user do not customize a theme, then what happens?
Which resources are used? The problem may arise from
that point.
  Sedat

> > >
> > > Just checked 'sotto' & 'brushmetal' theme (both
> shipped with roller)
> > > and they use $url.resource() and not
> $url.themeResource().
> > >
> > > Is this right?
> >
> > yes, that is correct and it's *imperative* that
> you use $url.resource()
> > this way to prevent pointers to shared resources.
> 
> So what is the problem? Is it simply that the themes
> need to be
> updated for the new encapsulated theme support?
> 
> - Dave
> 
> 
> 
> >
> > -- Allen
> >
> >
> > >
> > > - Richard
> > >
> > >
> > >
> > > On 07/05/07, Dave <sn...@gmail.com> wrote:
> > >> On 5/5/07, sedat ciftci <se...@yahoo.com>
> wrote:
> > >> > In roller 3.1 oprional themes,
> $url.resource(String
> > >> > file)  macro is used to get the resources
> > >> > (images,styles etc) of a theme. But this will
> not
> > >> > work, and the appearance of theme is not seen
> > >> > correctly. I change the usage of
> $url.resource(String
> > >> > file) with $url.themeResource(String theme,
> String
> > >> > file) macro and the themes are working
> correctly now.
> > >> >   Sedat
> > >>
> > >> Thanks for pointing that out. I filed a bug so
> that we don't forget to
> > >> fix this:
> > >>
>
http://opensource.atlassian.com/projects/roller/browse/ROL-1406
> > >>
> > >> - Dave
> > >>
> > >>
> > >> >
> > >> >
> __________________________________________________
> > >> > Do You Yahoo!?
> > >> > Tired of spam?  Yahoo! Mail has the best spam
> protection around
> > >> > http://mail.yahoo.com
> > >> >
> > >>
> > >>
> >
> 



 
____________________________________________________________________________________
Bored stiff? Loosen up... 
Download and play hundreds of games for free on Yahoo! Games.
http://games.yahoo.com/games/front

Re: problem in Roller 3.1 optional themes

Posted by Dave <sn...@gmail.com>.
On 5/7/07, Allen Gilliland <al...@sun.com> wrote:
> Richard Jones wrote:
> > Correct me if I'm wrong but I thought that now in 3.1 we were using
> > $url.resource() as opposed to $url.themeResource()...  because now the
> > resources are copied across when you customize a theme so instead of
> > using the original theme resource, you would use your own copy.
> >
> > Just checked 'sotto' & 'brushmetal' theme (both shipped with roller)
> > and they use $url.resource() and not $url.themeResource().
> >
> > Is this right?
>
> yes, that is correct and it's *imperative* that you use $url.resource()
> this way to prevent pointers to shared resources.

So what is the problem? Is it simply that the themes need to be
updated for the new encapsulated theme support?

- Dave



>
> -- Allen
>
>
> >
> > - Richard
> >
> >
> >
> > On 07/05/07, Dave <sn...@gmail.com> wrote:
> >> On 5/5/07, sedat ciftci <se...@yahoo.com> wrote:
> >> > In roller 3.1 oprional themes, $url.resource(String
> >> > file)  macro is used to get the resources
> >> > (images,styles etc) of a theme. But this will not
> >> > work, and the appearance of theme is not seen
> >> > correctly. I change the usage of $url.resource(String
> >> > file) with $url.themeResource(String theme, String
> >> > file) macro and the themes are working correctly now.
> >> >   Sedat
> >>
> >> Thanks for pointing that out. I filed a bug so that we don't forget to
> >> fix this:
> >> http://opensource.atlassian.com/projects/roller/browse/ROL-1406
> >>
> >> - Dave
> >>
> >>
> >> >
> >> > __________________________________________________
> >> > Do You Yahoo!?
> >> > Tired of spam?  Yahoo! Mail has the best spam protection around
> >> > http://mail.yahoo.com
> >> >
> >>
> >>
>

Re: problem in Roller 3.1 optional themes

Posted by Allen Gilliland <al...@sun.com>.

Richard Jones wrote:
> Correct me if I'm wrong but I thought that now in 3.1 we were using
> $url.resource() as opposed to $url.themeResource()...  because now the
> resources are copied across when you customize a theme so instead of
> using the original theme resource, you would use your own copy.
> 
> Just checked 'sotto' & 'brushmetal' theme (both shipped with roller)
> and they use $url.resource() and not $url.themeResource().
> 
> Is this right?

yes, that is correct and it's *imperative* that you use $url.resource() 
this way to prevent pointers to shared resources.

-- Allen


> 
> - Richard
> 
> 
> 
> On 07/05/07, Dave <sn...@gmail.com> wrote:
>> On 5/5/07, sedat ciftci <se...@yahoo.com> wrote:
>> > In roller 3.1 oprional themes, $url.resource(String
>> > file)  macro is used to get the resources
>> > (images,styles etc) of a theme. But this will not
>> > work, and the appearance of theme is not seen
>> > correctly. I change the usage of $url.resource(String
>> > file) with $url.themeResource(String theme, String
>> > file) macro and the themes are working correctly now.
>> >   Sedat
>>
>> Thanks for pointing that out. I filed a bug so that we don't forget to 
>> fix this:
>> http://opensource.atlassian.com/projects/roller/browse/ROL-1406
>>
>> - Dave
>>
>>
>> >
>> > __________________________________________________
>> > Do You Yahoo!?
>> > Tired of spam?  Yahoo! Mail has the best spam protection around
>> > http://mail.yahoo.com
>> >
>>
>>

Re: problem in Roller 3.1 optional themes

Posted by Richard Jones <fu...@gmail.com>.
Correct me if I'm wrong but I thought that now in 3.1 we were using
$url.resource() as opposed to $url.themeResource()...  because now the
resources are copied across when you customize a theme so instead of
using the original theme resource, you would use your own copy.

Just checked 'sotto' & 'brushmetal' theme (both shipped with roller)
and they use $url.resource() and not $url.themeResource().

Is this right?

- Richard



On 07/05/07, Dave <sn...@gmail.com> wrote:
> On 5/5/07, sedat ciftci <se...@yahoo.com> wrote:
> > In roller 3.1 oprional themes, $url.resource(String
> > file)  macro is used to get the resources
> > (images,styles etc) of a theme. But this will not
> > work, and the appearance of theme is not seen
> > correctly. I change the usage of $url.resource(String
> > file) with $url.themeResource(String theme, String
> > file) macro and the themes are working correctly now.
> >   Sedat
>
> Thanks for pointing that out. I filed a bug so that we don't forget to fix this:
> http://opensource.atlassian.com/projects/roller/browse/ROL-1406
>
> - Dave
>
>
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Tired of spam?  Yahoo! Mail has the best spam protection around
> > http://mail.yahoo.com
> >
>
>

Re: problem in Roller 3.1 optional themes

Posted by Dave <sn...@gmail.com>.
On 5/5/07, sedat ciftci <se...@yahoo.com> wrote:
> In roller 3.1 oprional themes, $url.resource(String
> file)  macro is used to get the resources
> (images,styles etc) of a theme. But this will not
> work, and the appearance of theme is not seen
> correctly. I change the usage of $url.resource(String
> file) with $url.themeResource(String theme, String
> file) macro and the themes are working correctly now.
>   Sedat

Thanks for pointing that out. I filed a bug so that we don't forget to fix this:
http://opensource.atlassian.com/projects/roller/browse/ROL-1406

- Dave


>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam?  Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
>