You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/04/08 15:05:26 UTC
[GitHub] [accumulo-examples] DomGarguilo opened a new pull request, #99: Fix sample example - update compaction configuration
DomGarguilo opened a new pull request, #99:
URL: https://github.com/apache/accumulo-examples/pull/99
Fixes #65
This PR moves from the deprecated CompactionStategyConfig to the new CompactionConfig to setup the compations for this example.
I'm not certain that this is behaving how we are expecting it to, however the errors are not present and the output looks as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] DomGarguilo merged pull request #99: Fix sample example - update compaction configuration
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #99:
URL: https://github.com/apache/accumulo-examples/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] ctubbsii commented on a diff in pull request #99: Fix sample example - update compaction configuration
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #99:
URL: https://github.com/apache/accumulo-examples/pull/99#discussion_r847612493
##########
src/main/java/org/apache/accumulo/examples/sample/SampleExample.java:
##########
@@ -144,6 +143,7 @@ public static void main(String[] args) throws Exception {
System.out.println("Scanning with new sampler configuration : ");
print(scanner);
+ scanner.close();
Review Comment:
This should be in a try-with-resources block instead of an explicit close call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] jmark99 commented on pull request #99: Fix sample example - update compaction configuration
Posted by GitBox <gi...@apache.org>.
jmark99 commented on PR #99:
URL: https://github.com/apache/accumulo-examples/pull/99#issuecomment-1093118350
@DomGarguilo sorry about the false alarm. Something happened and the SampleExample class was not updated correctly when I ran it. Re-downloaded and successfully ran the example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] DomGarguilo commented on a diff in pull request #99: Fix sample example - update compaction configuration
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #99:
URL: https://github.com/apache/accumulo-examples/pull/99#discussion_r847654849
##########
src/main/java/org/apache/accumulo/examples/sample/SampleExample.java:
##########
@@ -144,6 +143,7 @@ public static void main(String[] args) throws Exception {
System.out.println("Scanning with new sampler configuration : ");
print(scanner);
+ scanner.close();
Review Comment:
Addressed in [b31cf77](https://github.com/apache/accumulo-examples/pull/99/commits/b31cf77b86909f2e6ee239081a749a5dd6c2d0d5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] jmark99 commented on pull request #99: Fix sample example - update compaction configuration
Posted by GitBox <gi...@apache.org>.
jmark99 commented on PR #99:
URL: https://github.com/apache/accumulo-examples/pull/99#issuecomment-1093098837
@DomGarguilo I cloned your PR and went through the step-by-step procedures with no issue. But when running the SampleExample I'm still seeing an exception related to the CompactionStrategy class.
`
$ ./bin/runex sample.SampleExample
Scanning all data :
2317 doc:context [] 1649437430445 false milk, eggs, bread, parmigiano-reggiano
2317 doc:url [] 1649437430445 false file://groceries/9/txt
3900 doc:context [] 1649437430445 false EC2 ate my homework
3900 doc:url [] 1649437430445 false file://final_project.txt
8934 doc:context [] 1649437430445 false accumulo scales
8934 doc:url [] 1649437430445 false file://accumulo_notes.txt
9225 doc:context [] 1649437430445 false abcde
9225 doc:url [] 1649437430445 false file://foo.txt
Scanning with sampler configuration. Data was written before sampler was set on table, scan should fail.
Saw sample not present exception as expected.
Exception in thread "main" org.apache.accumulo.core.client.AccumuloException: TabletServer could not load CompactionStrategy class org.apache.accumulo.tserver.compaction.strategies.ConfigurableCompactionStrategy
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.ensureStrategyCanLoad(TableOperationsImpl.java:914)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.compact(TableOperationsImpl.java:865)
at org.apache.accumulo.examples.sample.SampleExample.main(SampleExample.java:107)
`
Did you see the error or do I have something misconfigured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-examples] DomGarguilo commented on pull request #99: Fix sample example - update compaction configuration
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #99:
URL: https://github.com/apache/accumulo-examples/pull/99#issuecomment-1093101702
@jmark99 did you add the accumulo-examples.jar and accumulo-examples-shaded.jar to the `/lib` directory of your Accumulo instance? I've recently run into something similar and that is what was causing the error for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org