[GitHub] [ozone] ChenSammi commented on a diff in pull request #5157: HDDS-9046. [ozone-cert-rotation] cert clean is unable to cleanup certificates LOCK error

["ChenSammi (via GitHub)" <gi...@apache.org>]

ChenSammi commented on code in PR #5157:
URL: https://github.com/apache/ozone/pull/5157#discussion_r1288250956


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java:
##########
@@ -508,6 +508,16 @@ public long revokeCertificates(List<String> certIds, int reason,
     }
   }
 
+  @Override
+  public List<String> clearExpiredCertificates() throws IOException {
+    List<String> pemEncodedCerts = new ArrayList<>();

Review Comment:
   I would suggest add the isAdmin check here. Here is an example.
   
    storageContainerManager.checkAdminAccess(getRpcRemoteUser(), false);



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org