You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2009/12/14 19:03:18 UTC
[jira] Created: (QPID-2270) Refactor TCPConnector class to its own
header file
Refactor TCPConnector class to its own header file
--------------------------------------------------
Key: QPID-2270
URL: https://issues.apache.org/jira/browse/QPID-2270
Project: Qpid
Issue Type: Sub-task
Components: C++ Client
Affects Versions: 0.6
Reporter: Steve Huston
Assignee: Steve Huston
Fix For: 0.6
The Windows SSL support will leverage the TCPConnector class declaration. To do this, TCPConnector will be moved to its own .h file (from TCPConnector.cpp) and the void connected() method changed to virtual.
The SSL support on Windows will be done as a shim inserted between TCPConnector and AsynchIO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2270) Refactor TCPConnector class to its own
header file
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-2270.
--------------------------------
Resolution: Fixed
Completed; trunk r890481
> Refactor TCPConnector class to its own header file
> --------------------------------------------------
>
> Key: QPID-2270
> URL: https://issues.apache.org/jira/browse/QPID-2270
> Project: Qpid
> Issue Type: Sub-task
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Steve Huston
> Assignee: Steve Huston
> Fix For: 0.6
>
>
> The Windows SSL support will leverage the TCPConnector class declaration. To do this, TCPConnector will be moved to its own .h file (from TCPConnector.cpp) and the void connected() method changed to virtual.
> The SSL support on Windows will be done as a shim inserted between TCPConnector and AsynchIO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2270) Refactor TCPConnector class to its
own header file
Posted by "Andrew Stitcher (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790486#action_12790486 ]
Andrew Stitcher commented on QPID-2270:
---------------------------------------
Whilst I think that the TCPConnector should indeed be in it's own file, and I support that change.
I'm very much against using inheritance as an extension mechanism to reuse existing implementation code, and it looks exactly like this is the strategy here otherwise you would be able to follow the example of the other Connector implementations and have the class definition inline with the implentation, both in the TCPConnector.cpp file.
> Refactor TCPConnector class to its own header file
> --------------------------------------------------
>
> Key: QPID-2270
> URL: https://issues.apache.org/jira/browse/QPID-2270
> Project: Qpid
> Issue Type: Sub-task
> Components: C++ Client
> Affects Versions: 0.6
> Reporter: Steve Huston
> Assignee: Steve Huston
> Fix For: 0.6
>
>
> The Windows SSL support will leverage the TCPConnector class declaration. To do this, TCPConnector will be moved to its own .h file (from TCPConnector.cpp) and the void connected() method changed to virtual.
> The SSL support on Windows will be done as a shim inserted between TCPConnector and AsynchIO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org