You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2025/01/23 03:24:46 UTC
[I] Improve performance of update metrics [datafusion-comet]
wForget opened a new issue, #1328:
URL: https://github.com/apache/datafusion-comet/issues/1328
### What is the problem the feature request solves?
When I profiled tpcds q64, I found that update_metrics took 8.9 % of task time.
### Describe the potential solution
I propose the following improvements to optimize update metrics:
+ Define a `NativeMetricNode` proto type to pass all metric nodes at once to avoid recursive jni calls.
+ Call update metrics when releasing plan to reduce the number of calls.
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Improve performance of update metrics [datafusion-comet]
Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on issue #1328:
URL: https://github.com/apache/datafusion-comet/issues/1328#issuecomment-2608943518
Similar to https://github.com/apache/datafusion-comet/issues/391#issuecomment-2411913476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Improve performance of update metrics [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #1328: Improve performance of update metrics
URL: https://github.com/apache/datafusion-comet/issues/1328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org