You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mkindahl (via GitHub)" <gi...@apache.org> on 2023/06/17 07:42:05 UTC
[GitHub] [arrow] mkindahl opened a new pull request, #36140: Fix typo for IWYU pragma
mkindahl opened a new pull request, #36140:
URL: https://github.com/apache/arrow/pull/36140
### Rationale for this change
The API file contains "IYWU" rather than "IWYU" for the export pragma.
### What changes are included in this PR?
The typos are corrected.
### Are these changes tested?
Since these are only comment changes, I did not test the change.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mkindahl commented on pull request #36140: MINOR: [C++] Fix typo for IWYU pragma
Posted by "mkindahl (via GitHub)" <gi...@apache.org>.
mkindahl commented on PR #36140:
URL: https://github.com/apache/arrow/pull/36140#issuecomment-1596137552
Added that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36140: MINOR: [C++] Fix typo for IWYU pragma
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36140:
URL: https://github.com/apache/arrow/pull/36140#issuecomment-1597791552
Conbench analyzed the 6 benchmark runs on commit `e798e2a0`.
There were 6 benchmark results indicating a performance regression:
- Commit Run on `arm64-t4g-linux-compute` at [2023-06-18 23:46:08Z](http://conbench.ursa.dev/compare/runs/7e65b47734d047e2a451f697c8096402...fa136de6191d4304892f9d6e903a770e/)
- [params=complex_expression/batch_size:100000/null_prob:0/bool_true_prob:50/real_time, source=cpp-micro, suite=arrow-acero-filter-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648f8bf25967d3b800076691408d18d...0648f979baa476bc8000abac6408de9b)
- Commit Run on `ursa-thinkcentre-m75q` at [2023-06-19 04:22:06Z](http://conbench.ursa.dev/compare/runs/0816f9777792449fb13334b9c76c8a27...af40cafbc20c4534be7eff0707bdb47a/)
- [params=4096, source=cpp-micro, suite=parquet-encoding-benchmark](http://conbench.ursa.dev/compare/benchmarks/0648faf9a4c771af8000c31c72e207a7...0648fd85dea873ec80006326fbdff85f)
- and 4 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14386237156) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mkindahl commented on pull request #36140: Fix typo for IWYU pragma
Posted by "mkindahl (via GitHub)" <gi...@apache.org>.
mkindahl commented on PR #36140:
URL: https://github.com/apache/arrow/pull/36140#issuecomment-1595659844
This just contains minor comment changes so I did not test it nor file an issue for it. If you want an issue or tests, please tell me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #36140: MINOR: [C++] Fix typo for IWYU pragma
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36140:
URL: https://github.com/apache/arrow/pull/36140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36140: Fix typo for IWYU pragma
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36140:
URL: https://github.com/apache/arrow/pull/36140#issuecomment-1595659757
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #36140: MINOR: [C++] Fix typo for IWYU pragma
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36140:
URL: https://github.com/apache/arrow/pull/36140#issuecomment-1595849749
Good catch!
It seems that we have the same typo in `cpp/src/parquet/thrift_internal.h`. Could you also fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org