You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/16 02:51:45 UTC
[GitHub] [flink] brandonJY opened a new pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
brandonJY opened a new pull request #13158:
URL: https://github.com/apache/flink/pull/13158
fix typo in checkpoint_monitoring doc
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
}, {
"hash" : "e29749fef5d6062e2a9290890d5863ef73265347",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557",
"triggerID" : "e29749fef5d6062e2a9290890d5863ef73265347",
"triggerType" : "PUSH"
}, {
"hash" : "1c1e0800bb49b1ee4953b08cc14c3c0112de3d87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c1e0800bb49b1ee4953b08cc14c3c0112de3d87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
* e29749fef5d6062e2a9290890d5863ef73265347 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557)
* 1c1e0800bb49b1ee4953b08cc14c3c0112de3d87 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13158:
URL: https://github.com/apache/flink/pull/13158#discussion_r471335941
##########
File path: docs/monitoring/checkpoint_monitoring.zh.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
- **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
- **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
- **End to End Duration**: The duration from the trigger timestamp until the latest acknowledgement (or n/a if no acknowledgement received yet). This end to end duration for a complete checkpoint is determined by the last subtask that acknowledges the checkpoint. This time is usually larger than single subtasks need to actually checkpoint the state.
-- **Checkpointed Data Size**: The state size over all acknowledged subtasks.
+- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value would be the delta delta checkpointed data if incremental checkpoint is on.
Review comment:
```suggestion
- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. If incremental checkpointing is enabled this value is the checkpointed data size delta.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] brandonJY commented on a change in pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
brandonJY commented on a change in pull request #13158:
URL: https://github.com/apache/flink/pull/13158#discussion_r471494574
##########
File path: docs/monitoring/checkpoint_monitoring.zh.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
- **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
- **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
- **End to End Duration**: The duration from the trigger timestamp until the latest acknowledgement (or n/a if no acknowledgement received yet). This end to end duration for a complete checkpoint is determined by the last subtask that acknowledges the checkpoint. This time is usually larger than single subtasks need to actually checkpoint the state.
-- **Checkpointed Data Size**: The state size over all acknowledged subtasks.
+- **Checkpointed Data Size**: The checkpointed data size over all acknowledged subtasks. This value would be the delta delta checkpointed data if incremental checkpoint is on.
Review comment:
@zentol updated per suggested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
}, {
"hash" : "e29749fef5d6062e2a9290890d5863ef73265347",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557",
"triggerID" : "e29749fef5d6062e2a9290890d5863ef73265347",
"triggerType" : "PUSH"
}, {
"hash" : "1c1e0800bb49b1ee4953b08cc14c3c0112de3d87",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5617",
"triggerID" : "1c1e0800bb49b1ee4953b08cc14c3c0112de3d87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
* e29749fef5d6062e2a9290890d5863ef73265347 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557)
* 1c1e0800bb49b1ee4953b08cc14c3c0112de3d87 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5617)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] brandonJY commented on a change in pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
brandonJY commented on a change in pull request #13158:
URL: https://github.com/apache/flink/pull/13158#discussion_r471495115
##########
File path: docs/monitoring/checkpoint_monitoring.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
- **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
- **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
Review comment:
Thanks for the review. Updated per suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
}, {
"hash" : "e29749fef5d6062e2a9290890d5863ef73265347",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557",
"triggerID" : "e29749fef5d6062e2a9290890d5863ef73265347",
"triggerType" : "PUSH"
}, {
"hash" : "1c1e0800bb49b1ee4953b08cc14c3c0112de3d87",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5617",
"triggerID" : "1c1e0800bb49b1ee4953b08cc14c3c0112de3d87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
* 1c1e0800bb49b1ee4953b08cc14c3c0112de3d87 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5617)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13158:
URL: https://github.com/apache/flink/pull/13158#discussion_r471348075
##########
File path: docs/monitoring/checkpoint_monitoring.md
##########
@@ -61,7 +61,7 @@ The checkpoint history keeps statistics about recently triggered checkpoints, in
- **Trigger Time**: The time when the checkpoint was triggered at the JobManager.
- **Latest Acknowledgement**: The time when the latest acknowledged for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
Review comment:
Could you also fix that one while reiterating over the file, please:
```suggestion
- **Latest Acknowledgement**: The time when the latest acknowledgement for any subtask was received at the JobManager (or n/a if no acknowledgement received yet).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
}, {
"hash" : "e29749fef5d6062e2a9290890d5863ef73265347",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557",
"triggerID" : "e29749fef5d6062e2a9290890d5863ef73265347",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
* e29749fef5d6062e2a9290890d5863ef73265347 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #13158:
URL: https://github.com/apache/flink/pull/13158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
}, {
"hash" : "e29749fef5d6062e2a9290890d5863ef73265347",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557",
"triggerID" : "e29749fef5d6062e2a9290890d5863ef73265347",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
* e29749fef5d6062e2a9290890d5863ef73265347 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5557)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674472407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6117c8b294a5fb0df0ec7fa5e95377890a650754",
"triggerType" : "PUSH"
}, {
"hash" : "e29749fef5d6062e2a9290890d5863ef73265347",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e29749fef5d6062e2a9290890d5863ef73265347",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6117c8b294a5fb0df0ec7fa5e95377890a650754 UNKNOWN
* e29749fef5d6062e2a9290890d5863ef73265347 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13158: [hotfix] [docs] Fix typo in checkpoint monitoring doc
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13158:
URL: https://github.com/apache/flink/pull/13158#issuecomment-674470723
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6117c8b294a5fb0df0ec7fa5e95377890a650754 (Sun Aug 16 02:53:21 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org