You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by resmo <gi...@git.apache.org> on 2015/06/23 16:06:34 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/513
CLOUDSTACK-8578: implement old behaviour for listing only non-destroy…
…ed VMs using state=present
Also see https://github.com/apache/cloudstack/pull/510#issuecomment-114502611
RFC @bhaisaab
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-8578-extend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/513.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #513
----
commit bf67382521e6df3e12b311fd11f21569564e3920
Author: Rene Moser <re...@apache.org>
Date: 2015-06-23T13:47:06Z
CLOUDSTACK-8578: implement old behaviour for listing only non-destroyed VMs using state=present
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/513#discussion_r33093929
--- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java ---
@@ -968,7 +968,11 @@
}
if (state != null) {
- sc.setParameters("stateEQ", state);
+ if (state.equalsIgnoreCase("present")) {
--- End diff --
Not sure if this make sense but is Expunged not !Present as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...
Posted by resmo <gi...@git.apache.org>.
Github user resmo commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/513#discussion_r33126603
--- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java ---
@@ -968,7 +968,11 @@
}
if (state != null) {
- sc.setParameters("stateEQ", state);
+ if (state.equalsIgnoreCase("present")) {
--- End diff --
Good catch, IMHO `Expunged` is not necessary but `Expunging` like we use for user e.g. https://github.com/resmo/cloudstack/blob/fix/CLOUDSTACK-8578-extend/server/src/com/cloud/api/query/QueryManagerImpl.java#L984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement state=present ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---