You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Andrey Mashenkov <an...@gmail.com> on 2018/11/26 11:19:47 UTC

[MTCGA] Disabled tests.

Hi Igniters,


I've found  "Cache 1" TC suite actually
starts IgniteBinaryCacheTestSuite.class suite.
This suite ignores several tests that has copies to be run with binary
marshaller:
* DataStreamProcessorSelfTest
* GridCacheAffinityRoutingSelfTest
* IgniteCacheAtomicLocalExpiryPolicyTest
* GridCacheEntryMemorySizeSelfTest
* GridCacheMvccSelfTest

Looks like these test were excluded from run as duplicates as they were a
part of another TC suite before BinaryMarshaller becomes a default
marshaller.

Quick investigation shows that
1. DataStreamProcessorSelfTest is DataStreamer test with keepBinary=false
mode and we never check this case
2. DataStreamProcessorBinarySelfTest (it's binary version) checks
keepBinary=true case within IgniteBinaryCacheTestSuite.


Should we stop ignoring mentioned tests or remove ones?
Thoughts?

-- 
Best regards,
Andrey V. Mashenkov

Re: [MTCGA] Disabled tests.

Posted by Andrey Mashenkov <an...@gmail.com>.

Thanks Ilya.

I've create a sub-ticket for IGNITE-9210:
https://issues.apache.org/jira/browse/IGNITE-10420

On Mon, Nov 26, 2018 at 2:22 PM Ilya Kasnacheev <il...@gmail.com>
wrote:

> Hello!
>
> I think we should un-ignore these tests. You can even create a sub-task
> under https://issues.apache.org/jira/browse/IGNITE-9210
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> пн, 26 нояб. 2018 г. в 14:20, Andrey Mashenkov <andrey.mashenkov@gmail.com
> >:
>
> > Hi Igniters,
> >
> >
> > I've found  "Cache 1" TC suite actually
> > starts IgniteBinaryCacheTestSuite.class suite.
> > This suite ignores several tests that has copies to be run with binary
> > marshaller:
> > * DataStreamProcessorSelfTest
> > * GridCacheAffinityRoutingSelfTest
> > * IgniteCacheAtomicLocalExpiryPolicyTest
> > * GridCacheEntryMemorySizeSelfTest
> > * GridCacheMvccSelfTest
> >
> > Looks like these test were excluded from run as duplicates as they were a
> > part of another TC suite before BinaryMarshaller becomes a default
> > marshaller.
> >
> > Quick investigation shows that
> > 1. DataStreamProcessorSelfTest is DataStreamer test with keepBinary=false
> > mode and we never check this case
> > 2. DataStreamProcessorBinarySelfTest (it's binary version) checks
> > keepBinary=true case within IgniteBinaryCacheTestSuite.
> >
> >
> > Should we stop ignoring mentioned tests or remove ones?
> > Thoughts?
> >
> > --
> > Best regards,
> > Andrey V. Mashenkov
> >
>


-- 
Best regards,
Andrey V. Mashenkov

Re: [MTCGA] Disabled tests.

Posted by Ilya Kasnacheev <il...@gmail.com>.

Hello!

I think we should un-ignore these tests. You can even create a sub-task
under https://issues.apache.org/jira/browse/IGNITE-9210

Regards,
-- 
Ilya Kasnacheev


пн, 26 нояб. 2018 г. в 14:20, Andrey Mashenkov <an...@gmail.com>:

> Hi Igniters,
>
>
> I've found  "Cache 1" TC suite actually
> starts IgniteBinaryCacheTestSuite.class suite.
> This suite ignores several tests that has copies to be run with binary
> marshaller:
> * DataStreamProcessorSelfTest
> * GridCacheAffinityRoutingSelfTest
> * IgniteCacheAtomicLocalExpiryPolicyTest
> * GridCacheEntryMemorySizeSelfTest
> * GridCacheMvccSelfTest
>
> Looks like these test were excluded from run as duplicates as they were a
> part of another TC suite before BinaryMarshaller becomes a default
> marshaller.
>
> Quick investigation shows that
> 1. DataStreamProcessorSelfTest is DataStreamer test with keepBinary=false
> mode and we never check this case
> 2. DataStreamProcessorBinarySelfTest (it's binary version) checks
> keepBinary=true case within IgniteBinaryCacheTestSuite.
>
>
> Should we stop ignoring mentioned tests or remove ones?
> Thoughts?
>
> --
> Best regards,
> Andrey V. Mashenkov
>