You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:24:15 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
ustcweizhou opened a new pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377
## Description
<!--- Describe your changes in detail -->
Steps to reproduce the issue
(1) change vm guest os type
(2) update vm template (guest os type is not changed)
(3) vm guest os type is reset to guest os type of template.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-708620248
<b>Trillian test result (tid-2943)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31904 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4377-t2943-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-708306987
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#discussion_r505515332
##########
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##########
@@ -2063,6 +2063,7 @@ private VMTemplateVO updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
ex.addProxyObject(String.valueOf(id), "templateId");
throw ex;
}
+ long oldGuestOSId = template.getGuestOSId();
Review comment:
moving before this line L#2096 `template = _tmpltDao.createForUpdate(id);` should be ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-709321823
k8s smoke test failure is env related. It failed to get ISO in ready state cc @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-704202613
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-709285243
@shwstppr i don't think these errors are relevant, can you comment? cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-704301816
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-704202899
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-704241230
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4377: server: fix issue that vm guest os type is reset after updatetemplate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4377:
URL: https://github.com/apache/cloudstack/pull/4377#issuecomment-708307745
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org