You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/10 15:08:48 UTC
[GitHub] [pulsar] rafaelsousa opened a new pull request #6029: [Issue 5958]
[helm] Apply fix to values-mini.yaml as well
rafaelsousa opened a new pull request #6029: [Issue 5958] [helm] Apply fix to values-mini.yaml as well
URL: https://github.com/apache/pulsar/pull/6029
### Motivation
The #5958 problem applies to values-mini.yaml, so I am proposing this pull request to help those using values in a dev environment.
### Modifications
Changed values in values-mini.yaml
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Deploy the application into a kubernetes local cluster with
helm install pulsar-cluster --values pulsar/values-mini.yaml pulsar
As the problem addresses specifically helm 3 users, this should install the pulsar-cluster with no problems.
### Documentation
- Does this pull request introduce a new feature? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] roman-popenov commented on issue #6029: [Issue 5958]
[helm] Apply fix to values-mini.yaml as well
Posted by GitBox <gi...@apache.org>.
roman-popenov commented on issue #6029: [Issue 5958] [helm] Apply fix to values-mini.yaml as well
URL: https://github.com/apache/pulsar/pull/6029#issuecomment-578760242
There is a mistake in the charts pulsar manager template file at line 65:
`{{ toYaml .Values.grafana.resources | indent 10 }}` should be `{{ toYaml .Values.pulsar_manager.resources | indent 12 }}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] rafaelsousa closed pull request #6029: [Issue 5958] [helm]
Apply fix to values-mini.yaml as well
Posted by GitBox <gi...@apache.org>.
rafaelsousa closed pull request #6029: [Issue 5958] [helm] Apply fix to values-mini.yaml as well
URL: https://github.com/apache/pulsar/pull/6029
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] roman-popenov edited a comment on issue #6029: [Issue
5958] [helm] Apply fix to values-mini.yaml as well
Posted by GitBox <gi...@apache.org>.
roman-popenov edited a comment on issue #6029: [Issue 5958] [helm] Apply fix to values-mini.yaml as well
URL: https://github.com/apache/pulsar/pull/6029#issuecomment-578760242
First line 63 should be:
` {{- if .Values.pulsar_manager.resources }}`
There is a mistake in the charts pulsar manager template file at line 65:
`{{ toYaml .Values.grafana.resources | indent 10 }}` should be `{{ toYaml .Values.pulsar_manager.resources | indent 12 }}`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] roman-popenov commented on issue #6029: [Issue 5958]
[helm] Apply fix to values-mini.yaml as well
Posted by GitBox <gi...@apache.org>.
roman-popenov commented on issue #6029: [Issue 5958] [helm] Apply fix to values-mini.yaml as well
URL: https://github.com/apache/pulsar/pull/6029#issuecomment-578341393
These issues go away with
Client and Server V17+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] roman-popenov removed a comment on issue #6029: [Issue
5958] [helm] Apply fix to values-mini.yaml as well
Posted by GitBox <gi...@apache.org>.
roman-popenov removed a comment on issue #6029: [Issue 5958] [helm] Apply fix to values-mini.yaml as well
URL: https://github.com/apache/pulsar/pull/6029#issuecomment-578341393
These issues go away with
Client and Server V17+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services