[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6828: Spark 3.3: Change default distribution modes

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6828:
URL: https://github.com/apache/iceberg/pull/6828#discussion_r1106037265


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -228,6 +228,16 @@ private DistributionMode adjustWriteDistributionMode(DistributionMode mode) {
     }
   }
 
+  private DistributionMode defaultDistributionMode() {
+    if (table.sortOrder().isSorted()) {
+      return RANGE;
+    } else if (table.spec().isPartitioned()) {
+      return HASH;
+    } else {
+      return NONE;

Review Comment:
   > What about exploring this separately?
   
   +1, the benefit seems to be not so straightforward to cluster by all columns. We can first have this generic default and then make more changes for unpartitioned case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org