You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2015/12/02 19:43:30 UTC
[GitHub] qpid-dispatch pull request: DISPATCH-190 - Exposed the protocol fa...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/38
DISPATCH-190 - Exposed the protocol family for the configuration of l…
…isteners and connectors. Modified relevant unit tests to use protocol family
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-190-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 3f556187108373ab10281308e7cf6fe24a15ea47
Author: ganeshmurthy <gm...@redhat.com>
Date: 2015-12-02T18:29:49Z
DISPATCH-190 - Exposed the protocol family for the configuration of listeners and connectors. Modified relevant unit tests to use protocol family
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-190 - Exposed the protocol fa...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/38#discussion_r46554871
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -633,7 +633,13 @@
"default": "both",
"description": "['in', 'out', 'both', 'no'] in: Strip the dispatch router specific annotations only on ingress; out: Strip the dispatch router specific annotations only on egress; both: Strip the dispatch router specific annotations on both ingress and egress; no - do not strip dispatch router specific annotations",
"create": true
- }
+ },
+ "protocolFamily": {
--- End diff --
Rather than duplicate this entry for both listener and connector, you could put this in the "addrPort" annotation. Like addr and port, protocolFamily is common to both entity types.
You have a default of IPv4 in the connector. That is inconsistent with the document string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-190 - Exposed the protocol fa...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request: DISPATCH-190 - Exposed the protocol fa...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/38#discussion_r46555717
--- Diff: include/qpid/dispatch/driver.h ---
@@ -142,12 +142,16 @@ void qdpn_driver_free(qdpn_driver_t *driver);
* @param[in] driver driver that will 'own' this listener
* @param[in] host local host address to listen on
* @param[in] port local port to listen on
+ * @param[in] protocol family to use (IPv4 or IPv6)
--- End diff --
You should include 0 as a valid option as well. It has a specific behavior. Likewise on connector.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org