You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/08/21 22:21:21 UTC
Review Request 61806: Updated depiction of runtime directory file
structure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61806/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305
Repository: mesos
Description
-------
This attempts to match the structure of the top level comments
in "slave/paths.hpp" and "slave/containerizer/mesos/paths.hpp".
The runtime directory tree/drawing now shows all potential entries
that can exist in the file structure and the potential nesting of
containers.
Diffs
-----
src/slave/containerizer/mesos/paths.hpp 12ae7c7329f9e8d334cb32c30cc38465bddc046c
Diff: https://reviews.apache.org/r/61806/diff/1/
Testing
-------
Comment change only.
Thanks,
Joseph Wu
Re: Review Request 61806: Updated depiction of runtime directory file
structure.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Aug. 21, 2017, 4:33 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/paths.hpp
> > Lines 54 (patched)
> > <https://reviews.apache.org/r/61806/diff/1/?file=1801260#file1801260line54>
> >
> > Align this field?
Ah whoops.
Was:
```
// | |-- <more nesting of containers>
// | |-- pid
```
Should be:
```
// | | |-- <more nesting of containers>
// | |-- pid
```
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61806/#review183411
-----------------------------------------------------------
On Aug. 21, 2017, 3:21 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61806/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 3:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This attempts to match the structure of the top level comments
> in "slave/paths.hpp" and "slave/containerizer/mesos/paths.hpp".
>
> The runtime directory tree/drawing now shows all potential entries
> that can exist in the file structure and the potential nesting of
> containers.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp 12ae7c7329f9e8d334cb32c30cc38465bddc046c
>
>
> Diff: https://reviews.apache.org/r/61806/diff/1/
>
>
> Testing
> -------
>
> Comment change only.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 61806: Updated depiction of runtime directory file
structure.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61806/#review183411
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/paths.hpp
Lines 54 (patched)
<https://reviews.apache.org/r/61806/#comment259427>
Align this field?
- Jie Yu
On Aug. 21, 2017, 10:21 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61806/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 10:21 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This attempts to match the structure of the top level comments
> in "slave/paths.hpp" and "slave/containerizer/mesos/paths.hpp".
>
> The runtime directory tree/drawing now shows all potential entries
> that can exist in the file structure and the potential nesting of
> containers.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp 12ae7c7329f9e8d334cb32c30cc38465bddc046c
>
>
> Diff: https://reviews.apache.org/r/61806/diff/1/
>
>
> Testing
> -------
>
> Comment change only.
>
>
> Thanks,
>
> Joseph Wu
>
>