[GitHub] [incubator-echarts] Ghostbird edited a comment on pull request #13469: Allow passing of DOM nodes to setContent

[GitBox <gi...@apache.org>]

Ghostbird edited a comment on pull request #13469:
URL: https://github.com/apache/incubator-echarts/pull/13469#issuecomment-714298136


   Retargeted to `next` branch.
   
   Didn't build for me unless I removed two invalid imports (outside the scope of this PR):
   
   ```diff
   diff --git a/src/coord/cartesian/Grid.ts b/src/coord/cartesian/Grid.ts
   index 5da228c2c..88c7d33ed 100644
   --- a/src/coord/cartesian/Grid.ts
   +++ b/src/coord/cartesian/Grid.ts
   @@ -38,7 +38,7 @@ import CoordinateSystemManager from '../../CoordinateSystem';
    import {ParsedModelFinder, SINGLE_REFERRING} from '../../util/model';
    
    // Depends on GridModel, AxisModel, which performs preprocess.
   -import GridModel, {defaultGridLayoutWithoutLabel, defaultGridLayoutWithLabel} from './GridModel';
   +import GridModel from './GridModel';
    import CartesianAxisModel from './AxisModel';
    import GlobalModel from '../../model/Global';
    import ExtensionAPI from '../../ExtensionAPI';
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org