You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2015/04/22 12:19:44 UTC
svn commit: r1675315 - in
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user:
AbstractGroupPrincipal.java GroupImpl.java
Author: angela
Date: Wed Apr 22 10:19:44 2015
New Revision: 1675315
URL: http://svn.apache.org/r1675315
Log:
OAK-2674 : Fix FindBug Issues
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AbstractGroupPrincipal.java
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AbstractGroupPrincipal.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AbstractGroupPrincipal.java?rev=1675315&r1=1675314&r2=1675315&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AbstractGroupPrincipal.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AbstractGroupPrincipal.java Wed Apr 22 10:19:44 2015
@@ -85,7 +85,7 @@ abstract class AbstractGroupPrincipal ex
// should not occur.
String msg = "Unable to retrieve Group members: " + e.getMessage();
log.error(msg);
- throw new IllegalStateException(msg);
+ throw new IllegalStateException(msg, e);
}
Iterator<Principal> principals = Iterators.transform(members, new Function<Authorizable, Principal>() {
@@ -99,7 +99,7 @@ abstract class AbstractGroupPrincipal ex
} catch (RepositoryException e) {
String msg = "Internal error while retrieving principal: " + e.getMessage();
log.error(msg);
- throw new IllegalStateException(msg);
+ throw new IllegalStateException(msg, e);
}
}
});
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java?rev=1675315&r1=1675314&r2=1675315&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java Wed Apr 22 10:19:44 2015
@@ -224,7 +224,7 @@ class GroupImpl extends AuthorizableImpl
/**
* Principal representation of this group instance.
*/
- private class GroupPrincipal extends AbstractGroupPrincipal {
+ private final class GroupPrincipal extends AbstractGroupPrincipal {
private GroupPrincipal(String principalName, Tree groupTree) {
super(principalName, groupTree, GroupImpl.this.getUserManager().getNamePathMapper());