You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Jerome Boulon (JIRA)" <ji...@apache.org> on 2008/10/16 20:29:45 UTC
[jira] Created: (HADOOP-4431) Add versionning/tags to Chukwa Chunk
Add versionning/tags to Chukwa Chunk
------------------------------------
Key: HADOOP-4431
URL: https://issues.apache.org/jira/browse/HADOOP-4431
Project: Hadoop Core
Issue Type: Improvement
Components: contrib/chukwa
Reporter: Jerome Boulon
add tags field
add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4431) Add versionning/tags to Chukwa Chunk
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated HADOOP-4431:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Jerome.
I chose the first version of the patch as you were right, I've opened an issue about the codestyle here: HADOOP-4504
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch, HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4431) Add versionning/tags to Chukwa Chunk
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon updated HADOOP-4431:
----------------------------------
Attachment: HADOOP-4431.patch
ChunkImpl versionning
ChunkImpl tests
Agent tags
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4431) Add versionning/tags to Chukwa
Chunk
Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640709#action_12640709 ]
Eric Yang commented on HADOOP-4431:
-----------------------------------
+1 important patch for chukwa chunk protocol versioning.
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4431) Add versionning/tags to Chukwa
Chunk
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642317#action_12642317 ]
Hudson commented on HADOOP-4431:
--------------------------------
Integrated in Hadoop-trunk #640 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/])
. Add versionning/tags to Chukwa Chunk.
(Jerome Boulon via Johan)
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch, HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4431) Add versionning/tags to Chukwa
Chunk
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640708#action_12640708 ]
Hadoop QA commented on HADOOP-4431:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392319/HADOOP-4431.patch
against trunk revision 705762.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 17 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3488/console
This message is automatically generated.
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4431) Add versionning/tags to Chukwa
Chunk
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640303#action_12640303 ]
Jerome Boulon commented on HADOOP-4431:
---------------------------------------
Add test class for ChunkImpl
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4431) Add versionning/tags to Chukwa Chunk
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon updated HADOOP-4431:
----------------------------------
Status: Patch Available (was: Open)
Patch available
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4431) Add versionning/tags to Chukwa
Chunk
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641001#action_12641001 ]
Johan Oskarsson commented on HADOOP-4431:
-----------------------------------------
The patch looks good but I'm going to be picky, there are a few places in the patch where the code style is a bit off. It's using tabs instead of two spaces for indentation and { in the wrong places etc. Please see: http://wiki.apache.org/hadoop/HowToContribute for more information.
Other then that it looks good. Could you please regenerate it and I'll commit it. Is the patch to marked as an incompatible change?
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4431) Add versionning/tags to Chukwa Chunk
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon updated HADOOP-4431:
----------------------------------
Attachment: HADOOP-4431.patch
Same patch with spaces instead of tabs but since tab were already there it may be better to commit the patch with the wrong indentation and create another Jira to change tab into space.
/Jerome.
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
> Attachments: HADOOP-4431.patch, HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4431) Add versionning/tags to Chukwa Chunk
Posted by "Jerome Boulon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Boulon reassigned HADOOP-4431:
-------------------------------------
Assignee: Jerome Boulon
> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
> Key: HADOOP-4431
> URL: https://issues.apache.org/jira/browse/HADOOP-4431
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Jerome Boulon
> Assignee: Jerome Boulon
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.