You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2011/04/04 21:27:11 UTC

[jira] [Created] (LUCENE-3012) if you use setNorm, lucene writes a headerless separate norms file

if you use setNorm, lucene writes a headerless separate norms file
------------------------------------------------------------------

                 Key: LUCENE-3012
                 URL: https://issues.apache.org/jira/browse/LUCENE-3012
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Robert Muir
            Assignee: Robert Muir
             Fix For: 3.1.1
         Attachments: LUCENE-3012.patch

In this case SR.reWrite just writes the bytes with no header...
we should write it always.

we can detect in these cases (segment written <= 3.1) with a 
sketchy length == maxDoc check.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3012) if you use setNorm, lucene writes a headerless separate norms file

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3012:
--------------------------------

    Fix Version/s:     (was: 3.1.1)
                   3.2

changing fix version to 3.2, especially given LUCENE-3014

> if you use setNorm, lucene writes a headerless separate norms file
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3012
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.2
>
>         Attachments: LUCENE-3012.patch
>
>
> In this case SR.reWrite just writes the bytes with no header...
> we should write it always.
> we can detect in these cases (segment written <= 3.1) with a 
> sketchy length == maxDoc check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3012) if you use setNorm, lucene writes a headerless separate norms file

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3012:
--------------------------------

    Attachment: LUCENE-3012.patch

> if you use setNorm, lucene writes a headerless separate norms file
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3012
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.1.1
>
>         Attachments: LUCENE-3012.patch
>
>
> In this case SR.reWrite just writes the bytes with no header...
> we should write it always.
> we can detect in these cases (segment written <= 3.1) with a 
> sketchy length == maxDoc check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3012) if you use setNorm, lucene writes a headerless separate norms file

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3012.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

Committed revision 1124366, 1124369

> if you use setNorm, lucene writes a headerless separate norms file
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3012
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-3012.patch, LUCENE-3012_3x.patch
>
>
> In this case SR.reWrite just writes the bytes with no header...
> we should write it always.
> we can detect in these cases (segment written <= 3.1) with a 
> sketchy length == maxDoc check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3012) if you use setNorm, lucene writes a headerless separate norms file

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3012:
--------------------------------

    Attachment: LUCENE-3012_3x.patch

Updated patch (against branch_3x for simplicity) that uses the LUCENE-3014 comparator API.

Because separate norms files are independent of the version that created the segment (e.g. one can call setNorm with 3.6 for a 3.1 segment), I think its really important that we fix this in 3.2 to write the header.

If there are no objections, I'd like to commit, and then regenerate the tentative 3.2 indexes for trunk's TestBackwardsCompatibility.

There's no need to change the fileformats.html documentation, as what we are doing now is actually inconsistent with it, thus the bug.


> if you use setNorm, lucene writes a headerless separate norms file
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3012
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.2
>
>         Attachments: LUCENE-3012.patch, LUCENE-3012_3x.patch
>
>
> In this case SR.reWrite just writes the bytes with no header...
> we should write it always.
> we can detect in these cases (segment written <= 3.1) with a 
> sketchy length == maxDoc check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3012) if you use setNorm, lucene writes a headerless separate norms file

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035459#comment-13035459 ] 

Michael McCandless commented on LUCENE-3012:
--------------------------------------------

I agree this is important to fix!

Patch looks good.


> if you use setNorm, lucene writes a headerless separate norms file
> ------------------------------------------------------------------
>
>                 Key: LUCENE-3012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3012
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.2
>
>         Attachments: LUCENE-3012.patch, LUCENE-3012_3x.patch
>
>
> In this case SR.reWrite just writes the bytes with no header...
> we should write it always.
> we can detect in these cases (segment written <= 3.1) with a 
> sketchy length == maxDoc check.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org