You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/09/15 20:34:26 UTC
Review Request 25654: Views : change view status names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25654/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-7314
https://issues.apache.org/jira/browse/AMBARI-7314
Repository: ambari
Description
-------
The view status names LOADING and LOADED should be changed to DEPLOYING and DEPLOYED to be inline with the current view event onDeploy.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 85e5906
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 09b63a4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java 5f025d9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java f2f488a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b6ec922
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1c6c792
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java fa342fe
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 4a429b6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProviderTest.java eebe0d3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 0e9d3d6
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java be0d3a6
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 0915325
ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 18b86ff
Diff: https://reviews.apache.org/r/25654/diff/
Testing
-------
All existing tests pass.
Thanks,
Tom Beerbower
Re: Review Request 25654: Views : change view status names
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25654/#review53373
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Sept. 15, 2014, 2:34 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25654/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 2:34 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7314
> https://issues.apache.org/jira/browse/AMBARI-7314
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The view status names LOADING and LOADED should be changed to DEPLOYING and DEPLOYED to be inline with the current view event onDeploy.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 85e5906
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 09b63a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java 5f025d9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java f2f488a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b6ec922
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1c6c792
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java fa342fe
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 4a429b6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProviderTest.java eebe0d3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 0e9d3d6
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java be0d3a6
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 0915325
> ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 18b86ff
>
> Diff: https://reviews.apache.org/r/25654/diff/
>
>
> Testing
> -------
>
> All existing tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25654: Views : change view status names
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25654/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 7 p.m.)
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-7314
https://issues.apache.org/jira/browse/AMBARI-7314
Repository: ambari
Description
-------
The view status names LOADING and LOADED should be changed to DEPLOYING and DEPLOYED to be inline with the current view event onDeploy.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 85e5906
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 09b63a4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java 5f025d9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java f2f488a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b6ec922
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1c6c792
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java fa342fe
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 4a429b6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProviderTest.java eebe0d3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 0e9d3d6
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java be0d3a6
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 0915325
ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 18b86ff
Diff: https://reviews.apache.org/r/25654/diff/
Testing
-------
All existing tests pass.
Thanks,
Tom Beerbower
Re: Review Request 25654: Views : change view status names
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25654/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 6:59 p.m.)
Review request for Ambari and Jonathan Hurley.
Changes
-------
Fixed status message to say deploying.
Bugs: AMBARI-7314
https://issues.apache.org/jira/browse/AMBARI-7314
Repository: ambari
Description
-------
The view status names LOADING and LOADED should be changed to DEPLOYING and DEPLOYED to be inline with the current view event onDeploy.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 85e5906
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 09b63a4
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java 5f025d9
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java f2f488a
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b6ec922
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1c6c792
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java fa342fe
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 4a429b6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProviderTest.java eebe0d3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 0e9d3d6
ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java be0d3a6
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 0915325
ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 18b86ff
Diff: https://reviews.apache.org/r/25654/diff/
Testing
-------
All existing tests pass.
Thanks,
Tom Beerbower
Re: Review Request 25654: Views : change view status names
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25654/#review53372
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
<https://reviews.apache.org/r/25654/#comment93016>
Do we care if the text says "Loading" or "Deploying"?
- Jonathan Hurley
On Sept. 15, 2014, 2:34 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25654/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 2:34 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-7314
> https://issues.apache.org/jira/browse/AMBARI-7314
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The view status names LOADING and LOADED should be changed to DEPLOYING and DEPLOYED to be inline with the current view event onDeploy.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProvider.java 85e5906
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 09b63a4
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java 5f025d9
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProvider.java f2f488a
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java b6ec922
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 1c6c792
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java fa342fe
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java 4a429b6
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProviderTest.java eebe0d3
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java 0e9d3d6
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewEntityTest.java be0d3a6
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 0915325
> ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 18b86ff
>
> Diff: https://reviews.apache.org/r/25654/diff/
>
>
> Testing
> -------
>
> All existing tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>