You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/08/23 09:30:57 UTC

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18896


Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................

IMPALA-11520: Remove functional.unsupported_types misc test

IMPALA-9482 added support to the remaining Hive types and removed the
functional.unsupported_types table. There was a misc exhaustive test
left, this commit removes this test.

Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
---
M testdata/workloads/functional-query/queries/QueryTest/misc.test
1 file changed, 0 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18896/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8496/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 25 Aug 2022 11:41:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 25 Aug 2022 11:41:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11221/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 25 Aug 2022 11:10:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 25 Aug 2022 11:14:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11210/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 09:52:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 25 Aug 2022 16:24:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18896/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18896/1//COMMIT_MSG@10
PS1, Line 10: There was a misc exhaustive test
            : left
This was a bit sneaky, as the test is not explicitly "exhaustive only", but it it is skipped for several file formats, including Parquet,while the test suite only runs with Parquet in core runs.

Can you add a TODO about this to https://github.com/apache/impala/blob/master/tests/query_test/test_queries.py#L186 ?



-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:25:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18896/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18896/1//COMMIT_MSG@10
PS1, Line 10: There was a misc exhaustive test
            : left
> This was a bit sneaky, as the test is not explicitly "exhaustive only", but
I see, I will rephrase the commit message with the next patch.
What would you like to add as a TODO there? To clean up the hidden exhaustive test?



-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 24 Aug 2022 07:07:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................

IMPALA-11520: Remove functional.unsupported_types misc test

IMPALA-9482 added support to the remaining Hive types and removed the
functional.unsupported_types table. There was a reference remaining in a
misc test. test_misc is not marked as exhaustive but it only runs in
exhaustive builds.

Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
---
M testdata/workloads/functional-query/queries/QueryTest/misc.test
M tests/query_test/test_queries.py
2 files changed, 1 insertion(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/18896/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................

IMPALA-11520: Remove functional.unsupported_types misc test

IMPALA-9482 added support to the remaining Hive types and removed the
functional.unsupported_types table. There was a reference remaining in a
misc test. test_misc is not marked as exhaustive but it only runs in
exhaustive builds.

Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Reviewed-on: http://gerrit.cloudera.org:8080/18896
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/misc.test
M tests/query_test/test_queries.py
2 files changed, 1 insertion(+), 12 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>

[Impala-ASF-CR] IMPALA-11520: Remove functional.unsupported types misc test

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18896 )

Change subject: IMPALA-11520: Remove functional.unsupported_types misc test
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18896/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18896/1//COMMIT_MSG@10
PS1, Line 10: There was a misc exhaustive test
            : left
> I see, I will rephrase the commit message with the next patch.
Yes, I mean't that the TODO should mention that this only runs in exhaustive, which doesn't seem intentional.



-- 
To view, visit http://gerrit.cloudera.org:8080/18896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b6ea5ac742fbcc427ad41741d347558cb7d110
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Wed, 24 Aug 2022 13:58:31 +0000
Gerrit-HasComments: Yes