You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/02/19 17:05:01 UTC

[GitHub] [incubator-echarts] mikeyshing88 opened a new pull request #12172: Fix: Calendar fix for DST

mikeyshing88 opened a new pull request #12172: Fix: Calendar fix for DST
URL: https://github.com/apache/incubator-echarts/pull/12172
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Fixes calendar chart layout when user is in a timezone with DST
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   https://github.com/apache/incubator-echarts/issues/12143
   https://github.com/apache/incubator-echarts/issues/10430
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   When user is in a timezone with DST, the last several months of the year on the calendar chart begin to overlap eachother.
   
   ![74432963-69a89a80-4e57-11ea-82b1-8320fea36821](https://user-images.githubusercontent.com/10422754/74856158-9407c580-5339-11ea-8f36-28ffc785b453.png)
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   The fix is based on the solution from https://github.com/apache/incubator-echarts/issues/10430
   
   ![Screenshot 2020-02-19 at 17 04 17](https://user-images.githubusercontent.com/10422754/74856369-eba63100-5339-11ea-8fe8-e177b7653870.png)
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12172: Fix: Calendar fix for DST
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-588329949
 
 
   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] Ovilia commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12172: Fix: Calendar fix for DST
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-604925265
 
 
   @damiangreen This PR is schedule for 4.8.0 so it will be reviewed soon. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] damiangreen commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
damiangreen commented on issue #12172: Fix: Calendar fix for DST
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-604934135
 
 
   Thanks @Ovilia , we're really looking forward to it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] damiangreen commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
damiangreen commented on issue #12172: Fix: Calendar fix for DST
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-596136425
 
 
   This fix works great for us, would be nice to get this merged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] mikeyshing88 edited a comment on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
mikeyshing88 edited a comment on issue #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-618478222


   @Ovilia I have checked the `master` branch recently and noticed that my changes have been reverted - do you mind confirming what happened please? Possible merge conflict issue?
   
   https://github.com/apache/incubator-echarts/commits/master/src/coord/calendar/Calendar.js


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] 100pah edited a comment on pull request #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
100pah edited a comment on pull request #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-618839295


   @mikeyshing88 Thanks for your carefully check. Sorry I should have made some comment.
   The PR is merged. But then I made little change based on the code located, because it seams not entirely perfect considering the context surrounding the code.
   The code snippet [behind the modified code](https://github.com/apache/incubator-echarts/commit/878829b46c4273b8a6793685b83bcecdb5313f8e#diff-c6ac7d8019f55c5a39e264462a77e161R394) was added before to the resolve another DST issue. But it did not do it correct in some cases we currently found. I modify it to cover this cases. I am not totally sure it is a best way to resolve DST issue in that way. But logically it seams correct to cover all of the cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] 100pah commented on pull request #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
100pah commented on pull request #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-618839295


   @mikeyshing88 Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] damiangreen commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
damiangreen commented on issue #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-617047981


   Great! When will it hit npm?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] Ovilia commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-617084674


   @damiangreen We need a few more weeks to go through Apache release progress, which usually takes about 2-4 weeks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] mikeyshing88 commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
mikeyshing88 commented on issue #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-618478222


   @Ovilia I have checked the `master` branch recently and noticed that my changes have been reverted - do you mind confirm what happened please?
   
   https://github.com/apache/incubator-echarts/commits/master/src/coord/calendar/Calendar.js


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12172: Fix: Calendar fix for DST

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12172:
URL: https://github.com/apache/incubator-echarts/pull/12172#issuecomment-616795999


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org