[GitHub] [superset] andrey-zayats commented on pull request #20645: refactor: Unify shared datasources reducers and actions

[GitBox <gi...@apache.org>]

andrey-zayats commented on PR #20645:
URL: https://github.com/apache/superset/pull/20645#issuecomment-1182408490

   hi @michael-s-molina. I found 2 issues while testing your pr. [ch-52581](https://app.shortcut.com/preset/story/52581/samples-section-returns-no-data-if-user-has-overwritten-the-chart), [ch-52589](https://app.shortcut.com/preset/story/52589/the-reverse-selection-option-freezes-when-the-user-turns-it-on-if-there-is-already-a-selected-value-in-the-value-filter). Can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org