You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Alex Boisvert (JIRA)" <ji...@apache.org> on 2008/12/19 19:45:44 UTC

[jira] Created: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

release task fails if there's a space in the path to the Buildfile
------------------------------------------------------------------

                 Key: BUILDR-230
                 URL: https://issues.apache.org/jira/browse/BUILDR-230
             Project: Buildr
          Issue Type: Bug
          Components: Core features
    Affects Versions: 1.3.3
            Reporter: Alex Boisvert
             Fix For: 1.3.4


Here's a transcript of a build log illustrating the issue:

2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
2008-12-18 16:51:10,123 [Thread-329946] WARN  - 

The issue is the --buildfile parameter value is not properly escaped for spaces:

--buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

Posted by "Joel Muzzerall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Muzzerall updated BUILDR-230:
----------------------------------

    Attachment: fix_for_buildr-230-try2.patch

Here is another try of the fix.  The sh has been moved into the make function and changed to the posted suggestion, and it seems to work.  The call to sh could now have a spec, but I'm not sure what the best way to do it is because it's called with 'command' and command is a protected function that the specs don't have access to.

> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
>                 Key: BUILDR-230
>                 URL: https://issues.apache.org/jira/browse/BUILDR-230
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3
>            Reporter: Alex Boisvert
>             Fix For: 1.3.4
>
>         Attachments: fix_for_buildr-230-try2.patch, fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN  - 
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658233#action_12658233 ] 

assafarkin edited comment on BUILDR-230 at 12/19/08 4:36 PM:
--------------------------------------------------------------

sh command,  "_#{Buildr::VERSION}_", 'clean', 'upload', *options

it should then be possible to spec this by checking the right arguments are passed, and in the right order.

      was (Author: assafarkin):
    sh command,  "_#{Buildr::VERSION}_", 'clean', 'upload', *options
  
> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
>                 Key: BUILDR-230
>                 URL: https://issues.apache.org/jira/browse/BUILDR-230
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3
>            Reporter: Alex Boisvert
>             Fix For: 1.3.4
>
>         Attachments: fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN  - 
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

Posted by "Joel Muzzerall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658230#action_12658230 ] 

Joel Muzzerall commented on BUILDR-230:
---------------------------------------

I think that other parts of the build process are effected by the space and that this problem is not solved yet.  My fix only solves the one error in the bug description.

> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
>                 Key: BUILDR-230
>                 URL: https://issues.apache.org/jira/browse/BUILDR-230
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3
>            Reporter: Alex Boisvert
>             Fix For: 1.3.4
>
>         Attachments: fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN  - 
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658233#action_12658233 ] 

Assaf Arkin commented on BUILDR-230:
------------------------------------

sh command,  "_#{Buildr::VERSION}_", 'clean', 'upload', *options

> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
>                 Key: BUILDR-230
>                 URL: https://issues.apache.org/jira/browse/BUILDR-230
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3
>            Reporter: Alex Boisvert
>             Fix For: 1.3.4
>
>         Attachments: fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN  - 
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Assaf Arkin resolved BUILDR-230.
--------------------------------

    Resolution: Fixed

Slightly different change. Going through sh with multiple arguments to avoid quoting, and relying on Rake to handle is properly.

> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
>                 Key: BUILDR-230
>                 URL: https://issues.apache.org/jira/browse/BUILDR-230
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3
>            Reporter: Alex Boisvert
>             Fix For: 1.3.4
>
>         Attachments: fix_for_buildr-230-try2.patch, fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN  - 
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-230) release task fails if there's a space in the path to the Buildfile

Posted by "Joel Muzzerall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joel Muzzerall updated BUILDR-230:
----------------------------------

    Attachment: fix_for_buildr-230.patch

Here's a fix.  Not sure what the best way to make a spec for this one is.  The line that triggers the symptom is in lib/buildr/core/build.rb in Release::buildr which is protected.  It's only called from Release::buildr, the specs for which stub out the make function.

> release task fails if there's a space in the path to the Buildfile
> ------------------------------------------------------------------
>
>                 Key: BUILDR-230
>                 URL: https://issues.apache.org/jira/browse/BUILDR-230
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3.3
>            Reporter: Alex Boisvert
>             Fix For: 1.3.4
>
>         Attachments: fix_for_buildr-230.patch
>
>
> Here's a transcript of a build log illustrating the issue:
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Triggering step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Checking necessary condition of step "buildr release".
> 2008-12-18 16:51:06,095 [Thread-329937] INFO  - Condition satisfied, running step "buildr release".
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - (in /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts, development)
> 2008-12-18 16:51:09,544 [Thread-329947] INFO  - Cleaning com.intalio.bre
> 2008-12-18 16:51:09,544 [Thread-329946] WARN  - /usr/bin/buildr _1.3.3_ clean upload --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next DEBUG=no --environment development
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - No Buildfile found (looking for: /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `expand_path': can't convert nil into String (TypeError)
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:152:in `buildfile'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `select'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:337:in `standard_exception_handling'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/lib/buildr/core/application.rb:161:in `run'
> 2008-12-18 16:51:10,104 [Thread-329946] WARN  - 	from /usr/lib/ruby/gems/1.8/gems/buildr-1.3.3/bin/buildr:20
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19:in `load'
> 2008-12-18 16:51:10,105 [Thread-329946] WARN  - 	from /usr/bin/buildr:19
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - buildr aborted!
> 2008-12-18 16:51:10,122 [Thread-329946] WARN  - Command failed with status (1): [/usr/bin/buildr _1.3.3_ clean upload --bui...]
> 2008-12-18 16:51:10,123 [Thread-329946] WARN  - 
> The issue is the --buildfile parameter value is not properly escaped for spaces:
> --buildfile /media/sdb1/home/release/tools/quickbuild-1.0.5/working/root/Intalio/Designer/Designer BRE plug-ins/branch-M3/Release-builds/checkouts/Buildfile.next

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.