You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/01 01:03:21 UTC

[GitHub] [superset] kamalkeshavani-aiinside opened a new issue, #20576: [SQL Lab] Saved Queries do not include parameters

kamalkeshavani-aiinside opened a new issue, #20576:
URL: https://github.com/apache/superset/issues/20576

   If a query with parameters is saved, the parameters are not stored with the query. So when executing a saved query, query fails without the necessary parameters.
   
   #### How to reproduce the bug
   
   1. Create a query with parameters
   2. Run and save the query
   3. Go to Saved Queries, and run in SQL Lab
   
   ### Expected results
   
   Saved Query should have the parameters.
   
   ### Actual results
   
   Saved Query does not have parameters.
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   
   
   ### Environment
   
   - browser type and version:
   - superset version: `master`
   Dockerhub image
   - any feature flags active: ENABLE_TEMPLATE_PROCESSING
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   In 'saved_query' table of metadata, there is column 'extra_json' which can/should be used to store the parameters.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kenho811 commented on issue #20576: [SQL Lab] Saved Queries do not include parameters

Posted by GitBox <gi...@apache.org>.
kenho811 commented on issue #20576:
URL: https://github.com/apache/superset/issues/20576#issuecomment-1264367419

   I confirm that this same behaviour persists in 2.0.0.
   
   ![image](https://user-images.githubusercontent.com/57944769/193412031-f9412abf-d5d1-42ae-ac6e-989fdd9d8790.png)
   
   
   I am not sure if it's meant to be like this, but It would be great that when the SQL template is saved in SQL Lab, the parameters are saved together as well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] nbalusu commented on issue #20576: [SQL Lab] Saved Queries do not include parameters

Posted by GitBox <gi...@apache.org>.
nbalusu commented on issue #20576:
URL: https://github.com/apache/superset/issues/20576#issuecomment-1191666452

   I have the same issue in 1.5.1. I was able to set parameters, after I saved the query I am not able to see saved parameters.. The only work around I figured is to save the parameters in description. copy params from description every time I run. Can someone please let me know If I miss any config to save params. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kamalkeshavani-aiinside closed issue #20576: [SQL Lab] Saved Queries do not include parameters

Posted by GitBox <gi...@apache.org>.
kamalkeshavani-aiinside closed issue #20576: [SQL Lab] Saved Queries do not include parameters
URL: https://github.com/apache/superset/issues/20576


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] divick commented on issue #20576: [SQL Lab] Saved Queries do not include parameters

Posted by "divick (via GitHub)" <gi...@apache.org>.
divick commented on issue #20576:
URL: https://github.com/apache/superset/issues/20576#issuecomment-1506754491

   I still see this issue in v2.0.1. Looking at the merged PR I see that it was committed and then reverted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org