[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #7221: [Veeam] Restore only a specified volume

["harikrishna-patnala (via GitHub)" <gi...@apache.org>]

harikrishna-patnala commented on code in PR #7221:
URL: https://github.com/apache/cloudstack/pull/7221#discussion_r1250687371


##########
api/src/main/java/org/apache/cloudstack/api/command/user/backup/RestoreVolumeFromBackupAndAttachToVMCmd.java:
##########
@@ -73,6 +74,12 @@ public class RestoreVolumeFromBackupAndAttachToVMCmd extends BaseAsyncCmd {
             description = "id of the VM where to attach the restored volume")
     private Long vmId;
 
+    @Parameter(name = ApiConstants.START_VM,
+            type = CommandType.BOOLEAN,
+            required = false,
+            description = "start VM after the restore is finished")

Review Comment:
   can you please add since param 



##########
plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java:
##########
@@ -27,6 +27,8 @@
 import java.util.Objects;
 import java.util.stream.Collectors;
 
+import com.cloud.storage.dao.VolumeDao;

Review Comment:
   please reorder this



##########
plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java:
##########
@@ -35,6 +35,7 @@
 import java.util.StringJoiner;
 import java.util.UUID;
 
+import com.cloud.utils.UuidUtils;

Review Comment:
   reorder please



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org