You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/19 08:19:39 UTC

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5797: fs/rpmsgfs: minor refine the return value

anchao commented on a change in pull request #5797:
URL: https://github.com/apache/incubator-nuttx/pull/5797#discussion_r830456793



##########
File path: fs/rpmsgfs/rpmsgfs_client.c
##########
@@ -453,12 +453,8 @@ off_t rpmsgfs_client_lseek(FAR void *handle, int fd,
     .whence = whence,
   };
 
-  int ret;
-
-  ret = rpmsgfs_send_recv(handle, RPMSGFS_LSEEK, true,
-          (struct rpmsgfs_header_s *)&msg, sizeof(msg), NULL);
-
-  return ret < 0 ? ret : ret;
+  return rpmsgfs_send_recv(handle, RPMSGFS_LSEEK, true,
+           (struct rpmsgfs_header_s *)&msg, sizeof(msg), NULL);

Review comment:
       Yes, which should be a separate PR, I will resolve the FAR issue later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org