You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Antonio Fornie <an...@gmail.com> on 2014/02/18 14:42:09 UTC
Review Request 18213: Fix and add some Rest unit and IT tests. Remove
duplication of site pugin declaration. Fix by adding a missing type of
RoutingConfig.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18213/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
Fix and add some Rest unit and IT tests. Remove duplication of site pugin
declaration. Fix by adding a missing type of RoutingConfig.
Diffs
-----
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 3861d63
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/RoutingTableRoutingConfig.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java fe41545
pom.xml d9bd2de
utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java d406f94
Diff: https://reviews.apache.org/r/18213/diff/
Testing
-------
Full maven lifecycle with unit and integration tests. Execute most of the functionality against our Ncira server.
Thanks,
Antonio Fornie
Re: Review Request 18213: Fix and add some Rest unit and IT tests. Remove
duplication of site pugin declaration. Fix by adding a missing type of
RoutingConfig.
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18213/#review34852
-----------------------------------------------------------
Ship it!
commit 96ffd7e655d7405cfcf99b679e9babe38253169d
Author: Antonio Fornie <af...@schubergphilis.com>
Date: Tue Feb 18 17:02:12 2014 +0100
Fix and add some Rest unit and IT tests. Fix by adding a missing type of RoutingConfig.
Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
- Hugo Trippaers
On Feb. 18, 2014, 4:09 p.m., Antonio Fornie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18213/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 4:09 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix and add some Rest unit and IT tests. Remove duplication of site pugin
> declaration. Fix by adding a missing type of RoutingConfig.
>
>
> Diffs
> -----
>
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 3861d63
> plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/RoutingTableRoutingConfig.java PRE-CREATION
> plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java fe41545
> utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java 17864b4
>
> Diff: https://reviews.apache.org/r/18213/diff/
>
>
> Testing
> -------
>
> Full maven lifecycle with unit and integration tests. Execute most of the functionality against our Ncira server.
>
>
> Thanks,
>
> Antonio Fornie
>
>
Re: Review Request 18213: Fix and add some Rest unit and IT tests. Remove
duplication of site pugin declaration. Fix by adding a missing type of
RoutingConfig.
Posted by Antonio Fornie <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18213/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 4:09 p.m.)
Review request for cloudstack, daan Hoogland and Hugo Trippaers.
Changes
-------
Can you check that this time there is no collision with Hugo's change on root pom (removal of site plugin duplication)?
Repository: cloudstack-git
Description
-------
Fix and add some Rest unit and IT tests. Remove duplication of site pugin
declaration. Fix by adding a missing type of RoutingConfig.
Diffs (updated)
-----
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 3861d63
plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/RoutingTableRoutingConfig.java PRE-CREATION
plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java fe41545
utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java 17864b4
Diff: https://reviews.apache.org/r/18213/diff/
Testing
-------
Full maven lifecycle with unit and integration tests. Execute most of the functionality against our Ncira server.
Thanks,
Antonio Fornie