You are viewing a plain text version of this content. The canonical link for it is here.

Posted to scm@geronimo.apache.org by jd...@apache.org on 2008/05/30 14:38:20 UTC

svn commit: r661690 - /geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java

Author: jdillon
Date: Fri May 30 05:38:19 2008
New Revision: 661690

URL: http://svn.apache.org/viewvc?rev=661690&view=rev
Log:
Throw exceptions when resolve() fails

Modified:
    geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java

Modified: geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java
URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java?rev=661690&r1=661689&r2=661690&view=diff
==============================================================================
--- geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java (original)
+++ geronimo/gshell/trunk/gshell-support/gshell-artifact/src/main/java/org/apache/geronimo/gshell/artifact/DefaultArtifactManager.java Fri May 30 05:38:19 2008
@@ -111,7 +111,13 @@
 
         log.debug("Validating result: {}", result);
 
-        if (/* TODO: detect failure */ false) {
+        if (result.hasErrorArtifactExceptions() ||
+            result.hasCircularDependencyExceptions() ||
+            result.hasMetadataResolutionExceptions() ||
+            result.hasVersionRangeViolations() ||
+            !result.getMissingArtifacts().isEmpty())
+        {
+            // Puke
             throw new ResolutionException(request, result);
         }