[jira] [Commented] (STORM-355) Duplicated netty dependency in lib classpath

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117818#comment-14117818 ] 

ASF GitHub Bot commented on STORM-355:
--------------------------------------

Github user danielcompton commented on the pull request:

    https://github.com/apache/incubator-storm/pull/148#issuecomment-54101048
  
    Has anyone examined whether there were any breaking changes in Netty between the version that Zookeeper was using and the version Storm was using? We came across this issue but weren't 100% sure it was safe to just exclude org.jboss.netty.


> Duplicated netty dependency in lib classpath
> --------------------------------------------
>
>                 Key: STORM-355
>                 URL: https://issues.apache.org/jira/browse/STORM-355
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>    Affects Versions: 0.9.2-incubating
>            Reporter: Krystian Nowak
>            Assignee: Krystian Nowak
>             Fix For: 0.9.3-incubating
>
>         Attachments: incubator-storm-STORM-355-pom.xml.patch
>
>
> Both _netty_ dependencies - [_3.2.2.Final_ (from _org.jboss.netty_)|http://search.maven.org/#artifactdetails|org.jboss.netty|netty|3.2.2.Final|bundle] and [_3.6.3.Final_ (from _io.netty_)|http://search.maven.org/#artifactdetails|io.netty|netty|3.6.3.Final|bundle] - are found in _lib_ folder:
> {noformat}
> knowak@knowak-dell:~/incubator-storm-0.9.2-incubating/storm-dist/binary/target/apache-storm-0.9.2-incubating/lib$ ls -al | grep netty
> -rw-rw-r-- 1 knowak knowak  785556 Jun 17 12:38 netty-3.2.2.Final.jar
> -rw-rw-r-- 1 knowak knowak 1202373 Jan 27 11:14 netty-3.6.3.Final.jar
> {noformat}
> as both of them are configured in _pom.xml_:
> {noformat}
> knowak@knowak-dell:~/incubator-storm-0.9.2-incubating/storm-core$ mvn dependency:list | grep netty
> [INFO]    io.netty:netty:jar:3.6.3.Final:compile
> [INFO]    org.jboss.netty:netty:jar:3.2.2.Final:compile
> {noformat}
> and it seems that the older one is transitively brought by [_zookeeper_ dependency|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]:
> {noformat}
> knowak@knowak-dell:~/incubator-storm-0.9.2-incubating/storm-core$ mvn dependency:tree
> ...
> [INFO] +- org.apache.curator:curator-framework:jar:2.4.0:compile
> [INFO] |  +- org.apache.curator:curator-client:jar:2.4.0:compile
> [INFO] |  \- org.apache.zookeeper:zookeeper:jar:3.4.5:compile
> [INFO] |     +- jline:jline:jar:2.11:compile
> [INFO] |     \- org.jboss.netty:netty:jar:3.2.2.Final:compile
> ...
> [INFO] +- io.netty:netty:jar:3.6.3.Final:compile
> ...
> {noformat}
> so possibly [_curator-framework_ dependency section|https://github.com/apache/incubator-storm/blob/master/pom.xml#L349] needs adding an exclusion of _org.jboss.netty_:_netty_



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)