You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mcmellawatt (GitHub)" <gi...@apache.org> on 2018/10/09 23:38:55 UTC

[GitHub] [geode] mcmellawatt opened pull request #2587: GEODE-5844: Eliminating String.Format() calls from initHelpMap()

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [] Have you written or updated unit tests to verify your changes?

- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2587: GEODE-5844: Eliminating String.Format() calls from initHelpMap()

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
We ran into a runtime error where we use the help map in SystemAdmin because of an argument mismatch.  This eliminates that problem by using '+' concatenation instead of String.Format.  Although '+' concatenation is slightly less performant than String.Format, this is not a concern in help documentation for this standalone tool, and it makes the code more readable.

[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2587: GEODE-5844: Eliminating String.Format() calls from initHelpMap()

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
We ran into a runtime error when we use the help map in SystemAdmin because of an argument count mismatch.  This eliminates that problem by using '+' concatenation instead of String.Format.  Although '+' concatenation is slightly less performant than String.Format, this is not a concern in help documentation for this standalone tool, and it makes the code more readable.

[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #2587: GEODE-5844: Eliminating String.Format() calls from initHelpMap()

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2587: GEODE-5844: Eliminating String.Format() calls from initHelpMap()

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
We ran into a runtime error where we use the help map in SystemAdmin because of an argument count mismatch.  This eliminates that problem by using '+' concatenation instead of String.Format.  Although '+' concatenation is slightly less performant than String.Format, this is not a concern in help documentation for this standalone tool, and it makes the code more readable.

[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2587: GEODE-5844: Eliminating String.Format() calls from initHelpMap()

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
We ran into a runtime error when we use the help map in SystemAdmin because of an argument count mismatch.  This PR eliminates that problem by using '+' concatenation instead of String.Format.  Although '+' concatenation is slightly less performant than String.Format, this is not a concern in help documentation for this standalone tool, and it makes the code more readable.

[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org