You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by rv...@apache.org on 2014/08/18 20:37:21 UTC
svn commit: r1618697 -
/jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
Author: rvesse
Date: Mon Aug 18 18:37:21 2014
New Revision: 1618697
URL: http://svn.apache.org/r1618697
Log:
Print a warning about being in Read Only mode to Fuseki logs when started without config file and without --update option
Modified:
jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
Modified: jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
URL: http://svn.apache.org/viewvc/jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java?rev=1618697&r1=1618696&r2=1618697&view=diff
==============================================================================
--- jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java (original)
+++ jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java Mon Aug 18 18:37:21 2014
@@ -449,8 +449,12 @@ public class FusekiCmd extends CmdARQ
Fuseki.configLog.info("Configuration file: "+fusekiConfigFile) ;
serverConfig = FusekiConfig.configure(fusekiConfigFile) ;
}
- else
+ else
+ {
serverConfig = FusekiConfig.defaultConfiguration(datasetPath, dsg, allowUpdate, listenLocal) ;
+ if ( ! allowUpdate )
+ Fuseki.configLog.warn("Running in read only mode, update functionality is disabled. Please restart with the --update option if you wish to run in read write mode");
+ }
// TODO Get from parsing config file.
serverConfig.port = port ;
Re: svn commit: r1618697 - /jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
Posted by Andy Seaborne <an...@apache.org>.
I saw that (or similar). The HTTP status code was right! What more do
people want?
I'll reword - I want to avoid any implication that update is normal;
servers may be web-facing and so it's safety first.
Andy
On 18/08/14 21:24, Rob Vesse wrote:
> Sure, I went with warning because I saw a discussion where a user hadn't
> realised they needed to add the --update argument so just something to
> make clear they are in read only mode
>
> If you think the wording/log level is too strong feel free to change it
>
> Rob
>
> On 18/08/2014 12:41, "Andy Seaborne" <an...@apache.org> wrote:
>
>> On 18/08/14 19:37, rvesse@apache.org wrote:
>>> Author: rvesse
>>> Date: Mon Aug 18 18:37:21 2014
>>> New Revision: 1618697
>>>
>>> URL: http://svn.apache.org/r1618697
>>> Log:
>>> Print a warning about being in Read Only mode to Fuseki logs when
>>> started without config file and without --update option
>>>
>>> Modified:
>>>
>>> jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>> a
>>>
>>> Modified:
>>> jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>> a
>>> URL:
>>> http://svn.apache.org/viewvc/jena/trunk/jena-fuseki/src/main/java/org/apa
>>> che/jena/fuseki/FusekiCmd.java?rev=1618697&r1=1618696&r2=1618697&view=dif
>>> f
>>>
>>> =========================================================================
>>> =====
>>> ---
>>> jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>> a (original)
>>> +++
>>> jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>> a Mon Aug 18 18:37:21 2014
>>> @@ -449,8 +449,12 @@ public class FusekiCmd extends CmdARQ
>>> Fuseki.configLog.info("Configuration file:
>>> "+fusekiConfigFile) ;
>>> serverConfig = FusekiConfig.configure(fusekiConfigFile) ;
>>> }
>>> - else
>>> + else
>>> + {
>>> serverConfig =
>>> FusekiConfig.defaultConfiguration(datasetPath, dsg, allowUpdate,
>>> listenLocal) ;
>>> + if ( ! allowUpdate )
>>> + Fuseki.configLog.warn("Running in read only mode,
>>> update functionality is disabled. Please restart with the --update
>>> option if you wish to run in read write mode");
>>> + }
>>
>> How about an INFO simply stating the fact? - starting in read-only mode
>> is quite reasonable and sensible.
>>
>> if ( ! allowUpdate )
>> Fuseki.configLog.info("Server running read-only") ;
>>
>> Andy
>>
>
>
>
>
Re: svn commit: r1618697 -
/jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
Posted by Rob Vesse <rv...@dotnetrdf.org>.
Sure, I went with warning because I saw a discussion where a user hadn't
realised they needed to add the --update argument so just something to
make clear they are in read only mode
If you think the wording/log level is too strong feel free to change it
Rob
On 18/08/2014 12:41, "Andy Seaborne" <an...@apache.org> wrote:
>On 18/08/14 19:37, rvesse@apache.org wrote:
>> Author: rvesse
>> Date: Mon Aug 18 18:37:21 2014
>> New Revision: 1618697
>>
>> URL: http://svn.apache.org/r1618697
>> Log:
>> Print a warning about being in Read Only mode to Fuseki logs when
>>started without config file and without --update option
>>
>> Modified:
>>
>>jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>a
>>
>> Modified:
>>jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>a
>> URL:
>>http://svn.apache.org/viewvc/jena/trunk/jena-fuseki/src/main/java/org/apa
>>che/jena/fuseki/FusekiCmd.java?rev=1618697&r1=1618696&r2=1618697&view=dif
>>f
>>
>>=========================================================================
>>=====
>> ---
>>jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>a (original)
>> +++
>>jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.jav
>>a Mon Aug 18 18:37:21 2014
>> @@ -449,8 +449,12 @@ public class FusekiCmd extends CmdARQ
>> Fuseki.configLog.info("Configuration file:
>>"+fusekiConfigFile) ;
>> serverConfig = FusekiConfig.configure(fusekiConfigFile) ;
>> }
>> - else
>> + else
>> + {
>> serverConfig =
>>FusekiConfig.defaultConfiguration(datasetPath, dsg, allowUpdate,
>>listenLocal) ;
>> + if ( ! allowUpdate )
>> + Fuseki.configLog.warn("Running in read only mode,
>>update functionality is disabled. Please restart with the --update
>>option if you wish to run in read write mode");
>> + }
>
>How about an INFO simply stating the fact? - starting in read-only mode
>is quite reasonable and sensible.
>
>if ( ! allowUpdate )
> Fuseki.configLog.info("Server running read-only") ;
>
> Andy
>
Re: svn commit: r1618697 - /jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
Posted by Andy Seaborne <an...@apache.org>.
On 18/08/14 19:37, rvesse@apache.org wrote:
> Author: rvesse
> Date: Mon Aug 18 18:37:21 2014
> New Revision: 1618697
>
> URL: http://svn.apache.org/r1618697
> Log:
> Print a warning about being in Read Only mode to Fuseki logs when started without config file and without --update option
>
> Modified:
> jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
>
> Modified: jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java
> URL: http://svn.apache.org/viewvc/jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java?rev=1618697&r1=1618696&r2=1618697&view=diff
> ==============================================================================
> --- jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java (original)
> +++ jena/trunk/jena-fuseki/src/main/java/org/apache/jena/fuseki/FusekiCmd.java Mon Aug 18 18:37:21 2014
> @@ -449,8 +449,12 @@ public class FusekiCmd extends CmdARQ
> Fuseki.configLog.info("Configuration file: "+fusekiConfigFile) ;
> serverConfig = FusekiConfig.configure(fusekiConfigFile) ;
> }
> - else
> + else
> + {
> serverConfig = FusekiConfig.defaultConfiguration(datasetPath, dsg, allowUpdate, listenLocal) ;
> + if ( ! allowUpdate )
> + Fuseki.configLog.warn("Running in read only mode, update functionality is disabled. Please restart with the --update option if you wish to run in read write mode");
> + }
How about an INFO simply stating the fact? - starting in read-only mode
is quite reasonable and sensible.
if ( ! allowUpdate )
Fuseki.configLog.info("Server running read-only") ;
Andy