[GitHub] trafficserver pull request #951: TS-4797: Allow backslash-escape in header_r...

[jpeach <gi...@git.apache.org>]

Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/951#discussion_r77249993
  
    --- Diff: plugins/header_rewrite/parser.cc ---
    @@ -50,6 +52,12 @@ Parser::Parser(const std::string &line) : _cond(false), _empty(false)
             _tokens.push_back(std::string(1, line[i]));
           }
           continue; /* always eat whitespace */
    +    } else if (line[i] == '\\') {
    +      // erase a backslash in quoted-string
    +      if (inquote && extracting_token) {
    --- End diff --
    
    Why the ``inquote`` condition? Why can't backquotes work outside of a quoted string?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---