You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by "Kevin A. McGrail" <KM...@PCCC.com> on 2014/09/10 20:42:31 UTC
Fwd: Rule priority
Can someone give him some guidance please? I'd like to support him
improving the plugin and I'm a bit busy with the RC for 3.4.1 and the SA
report.
-------- Forwarded Message --------
Subject: Rule priority
Date: Wed, 10 Sep 2014 11:06:01 -0600
From: Philip Prindeville <ph...@redfish-solutions.com>
To: SpamAssassin <us...@spamassassin.apache.org>
Is there a good discussion on how rule priority works, and short-circuited evaluation, etc?
I must be looking in the wrong places because I can’t find much. I found register_method_priority() in ::Plugin but I wasn’t sure if that’s all there is… It only seems to be called in Plugin::Reuse::new() (well, you’d expect it in the constructor).
Looking in the rules themselves, also, there aren’t that many rules which have an explicitly configured priority.
I ask because I’m trying to address this comment:
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7060#c10
but the source base doesn’t really contain a lot of useful examples.
Thanks,
-Philip
Re: Rule priority
Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 9/17/2014 7:05 PM, Philip Prindeville wrote:
> I guess it’s not a hot topic.
>
> Or else it’s not well understood.
I think it's the later. The short circuit plugin is likely not that
much used so perhaps document the issue in the plugin as a needed
enhancement and update the bug.
Beyond that, i encourage you to implement it AND document the priority
as best you can while you do it to help others behind us.
Best,
KAM
>
>
> On Sep 10, 2014, at 12:42 PM, Kevin A. McGrail <KMcGrail@PCCC.com
> <ma...@PCCC.com>> wrote:
>
>> Can someone give him some guidance please? I'd like to support him
>> improving the plugin and I'm a bit busy with the RC for 3.4.1 and the
>> SA report.
>>
>>
>> -------- Forwarded Message --------
>> Subject: Rule priority
>> Date: Wed, 10 Sep 2014 11:06:01 -0600
>> From: Philip Prindeville <ph...@redfish-solutions.com>
>> To: SpamAssassin <us...@spamassassin.apache.org>
>>
>>
>>
>> Is there a good discussion on how rule priority works, and short-circuited evaluation, etc?
>>
>> I must be looking in the wrong places because I can’t find much. I found register_method_priority() in ::Plugin but I wasn’t sure if that’s all there is… It only seems to be called in Plugin::Reuse::new() (well, you’d expect it in the constructor).
>>
>> Looking in the rules themselves, also, there aren’t that many rules which have an explicitly configured priority.
>>
>> I ask because I’m trying to address this comment:
>>
>> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7060#c10
>>
>> but the source base doesn’t really contain a lot of useful examples.
>>
>> Thanks,
>>
>> -Philip
>>
>>
>
Re: Rule priority
Posted by Philip Prindeville <ph...@redfish-solutions.com>.
I guess it’s not a hot topic.
Or else it’s not well understood.
On Sep 10, 2014, at 12:42 PM, Kevin A. McGrail <KM...@PCCC.com> wrote:
> Can someone give him some guidance please? I'd like to support him improving the plugin and I'm a bit busy with the RC for 3.4.1 and the SA report.
>
>
> -------- Forwarded Message --------
> Subject: Rule priority
> Date: Wed, 10 Sep 2014 11:06:01 -0600
> From: Philip Prindeville <ph...@redfish-solutions.com>
> To: SpamAssassin <us...@spamassassin.apache.org>
>
> Is there a good discussion on how rule priority works, and short-circuited evaluation, etc?
>
> I must be looking in the wrong places because I can’t find much. I found register_method_priority() in ::Plugin but I wasn’t sure if that’s all there is… It only seems to be called in Plugin::Reuse::new() (well, you’d expect it in the constructor).
>
> Looking in the rules themselves, also, there aren’t that many rules which have an explicitly configured priority.
>
> I ask because I’m trying to address this comment:
>
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7060#c10
>
> but the source base doesn’t really contain a lot of useful examples.
>
> Thanks,
>
> -Philip
>
>