You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/17 04:55:19 UTC
[GitHub] [yunikorn-core] manirajv06 opened a new pull request, #451: [YUNIKORN-1398] Remove non daemonset reservation from node before allocating daemonset pod
manirajv06 opened a new pull request, #451:
URL: https://github.com/apache/yunikorn-core/pull/451
### What is this PR for?
Cancel non daemon set reservations (if any) on specific node to give preference to daemon sets allocation during upscaling.
### What type of PR is it?
* [ ] - Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1398
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #451: [YUNIKORN-1398] Remove non daemonset reservation from node before allocating daemonset pod
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #451:
URL: https://github.com/apache/yunikorn-core/pull/451#issuecomment-1318098252
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#451](https://codecov.io/gh/apache/yunikorn-core/pull/451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (639d8c2) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/57f9abc094f6d2ec525951d0000feae5d2057653?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (57f9abc) will **decrease** coverage by `0.25%`.
> The diff coverage is `45.08%`.
```diff
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 72.50% 72.24% -0.26%
==========================================
Files 67 67
Lines 9820 9898 +78
==========================================
+ Hits 7120 7151 +31
- Misses 2459 2504 +45
- Partials 241 243 +2
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/node.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `79.72% <0.00%> (-1.77%)` | :arrow_down: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `56.06% <25.45%> (-1.38%)` | :arrow_down: |
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `75.28% <52.17%> (+0.06%)` | :arrow_up: |
| [pkg/scheduler/ugm/manager.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci91Z20vbWFuYWdlci5nbw==) | `58.17% <70.00%> (+3.12%)` | :arrow_up: |
| [pkg/scheduler/health\_checker.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9oZWFsdGhfY2hlY2tlci5nbw==) | `85.20% <100.00%> (ø)` | |
| [pkg/scheduler/objects/application\_state.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `100.00% <100.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `76.92% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] manirajv06 closed pull request #451: [YUNIKORN-1398] Remove non daemonset reservation from node before allocating daemonset pod
Posted by GitBox <gi...@apache.org>.
manirajv06 closed pull request #451: [YUNIKORN-1398] Remove non daemonset reservation from node before allocating daemonset pod
URL: https://github.com/apache/yunikorn-core/pull/451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org