You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/12/14 01:21:38 UTC
[GitHub] [gobblin] umustafi opened a new pull request, #3615: [GOBBLIN-1754] Fixes for mysql store change monitors
umustafi opened a new pull request, #3615:
URL: https://github.com/apache/gobblin/pull/3615
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1754
### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
Includes small fixes and logging added to change monitors, their initialization, and any related parts of code that the API and execution layer interact with.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Did manual integration test by deploying with other components to verify this is working.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3615: [GOBBLIN-1754] Fixes for mysql store change monitors
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on code in PR #3615:
URL: https://github.com/apache/gobblin/pull/3615#discussion_r1047913439
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandlerWithWarmStandby.java:
##########
@@ -53,8 +53,15 @@ public void resume(ComplexResourceKey<org.apache.gobblin.service.FlowStatusId, E
String flowName = key.getKey().getFlowName();
Long flowExecutionId = key.getKey().getFlowExecutionId();
try {
+ // If an existing resume or kill request is still pending then do not accept this request
+ if (this.dagActionStore.exists(flowGroup, flowName, flowExecutionId.toString())) {
+ this.handleException(flowGroup, flowName, flowExecutionId.toString(),
Review Comment:
Should we print out the existing action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] umustafi commented on a diff in pull request #3615: [GOBBLIN-1754] Fixes for mysql store change monitors
Posted by GitBox <gi...@apache.org>.
umustafi commented on code in PR #3615:
URL: https://github.com/apache/gobblin/pull/3615#discussion_r1048995779
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandlerWithWarmStandby.java:
##########
@@ -53,8 +53,15 @@ public void resume(ComplexResourceKey<org.apache.gobblin.service.FlowStatusId, E
String flowName = key.getKey().getFlowName();
Long flowExecutionId = key.getKey().getFlowExecutionId();
try {
+ // If an existing resume or kill request is still pending then do not accept this request
+ if (this.dagActionStore.exists(flowGroup, flowName, flowExecutionId.toString())) {
+ this.handleException(flowGroup, flowName, flowExecutionId.toString(),
Review Comment:
yes added to both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3615: [GOBBLIN-1754] Fixes for mysql store change monitors
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3615:
URL: https://github.com/apache/gobblin/pull/3615#issuecomment-1352265466
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3615](https://codecov.io/gh/apache/gobblin/pull/3615?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eef1259) into [master](https://codecov.io/gh/apache/gobblin/commit/d29bd9f32158bbc2cc9c9bbbdb90d565fb34b078?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d29bd9f) will **decrease** coverage by `0.01%`.
> The diff coverage is `2.70%`.
```diff
@@ Coverage Diff @@
## master #3615 +/- ##
============================================
- Coverage 46.91% 46.89% -0.02%
+ Complexity 10699 10695 -4
============================================
Files 2128 2128
Lines 83231 83256 +25
Branches 9275 9278 +3
============================================
Hits 39044 39044
- Misses 40598 40624 +26
+ Partials 3589 3588 -1
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3615?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/gobblin/runtime/kafka/HighLevelConsumer.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUva2Fma2EvSGlnaExldmVsQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ceFlowExecutionResourceHandlerWithWarmStandby.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93RXhlY3V0aW9uUmVzb3VyY2VIYW5kbGVyV2l0aFdhcm1TdGFuZGJ5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ervice/monitoring/DagActionStoreChangeMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9EYWdBY3Rpb25TdG9yZUNoYW5nZU1vbml0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...monitoring/DagActionStoreChangeMonitorFactory.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9EYWdBY3Rpb25TdG9yZUNoYW5nZU1vbml0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...lin/service/monitoring/SpecStoreChangeMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9TcGVjU3RvcmVDaGFuZ2VNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...vice/monitoring/SpecStoreChangeMonitorFactory.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9TcGVjU3RvcmVDaGFuZ2VNb25pdG9yRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../runtime/dag\_action\_store/MysqlDagActionStore.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZGFnX2FjdGlvbl9zdG9yZS9NeXNxbERhZ0FjdGlvblN0b3JlLmphdmE=) | `79.74% <50.00%> (-0.78%)` | :arrow_down: |
| [...odules/orchestration/InMemoryUserQuotaManager.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0luTWVtb3J5VXNlclF1b3RhTWFuYWdlci5qYXZh) | `70.07% <0.00%> (-0.79%)` | :arrow_down: |
| [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `15.03% <0.00%> (-0.66%)` | :arrow_down: |
| [...anagement/copy/replication/ConfigBasedDataset.java](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWREYXRhc2V0LmphdmE=) | `68.87% <0.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/gobblin/pull/3615/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 merged pull request #3615: [GOBBLIN-1754] Fixes for mysql store change monitors
Posted by GitBox <gi...@apache.org>.
ZihanLi58 merged PR #3615:
URL: https://github.com/apache/gobblin/pull/3615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org