[GitHub] [accumulo] milleruntime commented on a change in pull request #2160: Make CachableBlockFile builder require nonNull for cacheId

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2160:
URL: https://github.com/apache/accumulo/pull/2160#discussion_r651891798



##########
File path: core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
##########
@@ -347,7 +349,7 @@ public SamplerConfiguration getSamplerConfiguration() {
       for (int i = 0; i < sources.length; i++) {
         // TODO may have been a bug with multiple files and caching in older version...
         FSDataInputStream inputStream = (FSDataInputStream) sources[i].getInputStream();
-        CachableBuilder cb = new CachableBuilder().cacheId("source-" + i).input(inputStream)
+        CachableBuilder cb = new CachableBuilder().input(inputStream, "cache-" + rand + i)

Review comment:
       Reverted changing the cacheId 04920fb and just specified what was there in the builder method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org