You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by boneill42 <gi...@git.apache.org> on 2015/11/02 22:05:23 UTC

[GitHub] spark pull request: SPARK-11406: Patch for a utf-8 decode issue th...

Github user boneill42 commented on the pull request:

    https://github.com/apache/spark/pull/9360#issuecomment-153156312
  
    I don't believe the new signature for decode is available in 2.6....
    
    ```
    (spark)blu:streaming brianoneill$ python2.6
    Python 2.6.9 (unknown, Aug 22 2015, 20:33:41)
    >>> s = "foo"
    >>> s.decode('utf-8', errors='ignore')
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    TypeError: decode() takes no keyword arguments
    
    (spark)blu:streaming brianoneill$ python2.7
    Python 2.7.10 (default, Jul 13 2015, 12:05:58)
    >>> s = "foo"
    >>> s.decode('utf-8', errors='ignore')
    u'foo'
    ```
    
    I've left the code as-is, and added a test.  Update coming...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org