You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/14 13:43:52 UTC
[GitHub] [airflow] jpmarques66 opened a new pull request #10327: Move roles contributing
jpmarques66 opened a new pull request #10327:
URL: https://github.com/apache/airflow/pull/10327
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Adds [roles](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=62694605) to [CONTRIBUTING.rst](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst) as requested in #10184
Closes #10184
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068454
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
Review comment:
```suggestion
* Understanding of contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068428
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
Review comment:
```suggestion
* Understanding of Airflow Core or has displayed a holistic understanding of a particular part and made
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471095791
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471095437
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
Review comment:
As @potiuk suggested, I removed that part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683325226
Some checks were cancelled I think - it's best if you rebase on latest master and re-push @jpmarques66 -> then we can merge it with confidence :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683335483
Cool! Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068258
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
Review comment:
```suggestion
* Scanning and responding to Github issues
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683335646
Thanks @jpmarques66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068533
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
+* Visibility on discussions on the dev mailing list and the Slack channel
+* Testing Release Candidates to improve the release cycle
Review comment:
```suggestion
* Testing Release Candidates
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471088596
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
Review comment:
+1
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
Review comment:
```suggestion
* Quality of the commits
##########
File path: CONTRIBUTING.rst
##########
@@ -154,7 +219,7 @@ You can use the default Breeze configuration as follows:
.. code-block:: bash
- ./breeze --initialize-local-virtualenv
+ ./breeze initialize-local-virtualenv
Review comment:
I think not related but I would not obiect fixing it.
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
Review comment:
+1
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
Review comment:
yep
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
+* Visibility on discussions on the dev mailing list and the Slack channel
Review comment:
+1
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
Review comment:
yep
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
+* Visibility on discussions on the dev mailing list and the Slack channel
+* Testing Release Candidates to improve the release cycle
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471095344
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
Review comment:
Done.
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
Review comment:
done.
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
Review comment:
done.
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683398788
Thanks @jpmarques66 ! One step closer to clean docs ! Looking forward to next contributions!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r476638612
##########
File path: CONTRIBUTING.rst
##########
@@ -84,6 +84,70 @@ If you are proposing a new feature:
- Remember that this is a volunteer-driven project, and that contributions are
welcome :)
+
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
Review comment:
```suggestion
The official list of committers can be found `here <https://airflow.apache.org/docs/stable/project.html#committers>`__.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068504
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
Review comment:
What does it mean `asses the impact of the changes`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683324511
@kaxil thanks for the contribution 🙏. Should we merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683335446
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-683335341
@potiuk I think it looks good now. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068522
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
+* Visibility on discussions on the dev mailing list and the Slack channel
Review comment:
```suggestion
* Visibility in community discussions (on the dev mailing list, Slack and Github)
```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10327: Move roles contributing
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-674081764
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068282
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
Review comment:
```suggestion
* Responding to questions on the dev mailing list (dev@airflow.apache.org)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471095574
##########
File path: CONTRIBUTING.rst
##########
@@ -154,7 +219,7 @@ You can use the default Breeze configuration as follows:
.. code-block:: bash
- ./breeze --initialize-local-virtualenv
+ ./breeze initialize-local-virtualenv
Review comment:
Not related, just a typo I noticed when trying to use Breeze for the first time. If no one opposes, I'll keep it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#issuecomment-674572593
Good point @turbaszek . I think it should be seond one - "Contributing" should be first. WDYT @kaxil ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10327:
URL: https://github.com/apache/airflow/pull/10327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471068601
##########
File path: CONTRIBUTING.rst
##########
@@ -154,7 +219,7 @@ You can use the default Breeze configuration as follows:
.. code-block:: bash
- ./breeze --initialize-local-virtualenv
+ ./breeze initialize-local-virtualenv
Review comment:
Is this a related change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jpmarques66 commented on a change in pull request #10327: Move roles to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
jpmarques66 commented on a change in pull request #10327:
URL: https://github.com/apache/airflow/pull/10327#discussion_r471095471
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
+* Visibility on discussions on the dev mailing list and the Slack channel
Review comment:
@turbaszek Agreed.
##########
File path: CONTRIBUTING.rst
##########
@@ -17,6 +17,70 @@
.. contents:: :local:
+Roles
+=============
+
+There are several roles within the Airflow Open-Source community.
+
+
+PMC Member
+-----------
+The PMC (Project Management Committee) is a group of maintainers that drives changes in the way that
+Airflow is managed as a project.
+
+Considering Apache, the role of the PMC is primarily to ensure that Airflow conforms to Apache's processes
+and guidelines.
+
+Committers/Maintainers
+----------------------
+
+Committers are community members that have write access to the project’s repositories, i.e., they can modify the code,
+documentation, and website by themselves and also accept other contributions.
+
+The official list of committers can be found `here <https://airflow.apache.org/docs/>`__.
+
+Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
+
+* https://whimsy.apache.org/roster/ppmc/airflow
+* https://github.com/orgs/apache/teams/airflow-committers/members
+
+Committers are responsible for:
+
+* Championing one or more items on the `Roadmap <https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Home>`__
+* Reviewing & Merging Pull-Requests
+* Scanning and responding to JIRAs
+* Responding to questions on the dev mailing list (dev@airflow.incubator.apache.org)
+
+Becoming a Committer
+--------------------
+
+There is no strict protocol for becoming a committer.
+Candidates for new committers are typically people that are active contributors and community members.
+
+The key aspects of a committer are:
+
+* Consistent contributions over the past 6 months
+* Expressed understanding of Airflow Core or has displayed holistic understanding of a particular part and made
+ contributions towards a more strategic goal
+* Understands contributor/committer guidelines: `Contributors' Guide <https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst>`__
+* Quality of the commits, and asses the impact of the changes
+* Visibility on discussions on the dev mailing list and the Slack channel
+* Testing Release Candidates to improve the release cycle
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org