You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Alex Dean <al...@crackpot.org> on 2011/02/13 04:17:29 UTC
need review on ajax change
I attached a patch to fix https://issues.apache.org/jira/browse/AMQ-3123.
If a continuation is not available when AjaxListener receives a message, it buffers the message in a linked list for later delivery. (MessageListenerServlet checks for any messages buffered in this way.) The problem is that AjaxListener isn't currently maintaining the message<->consumer association, so some messages get associated with the wrong callback function when they're sent back to the web browser.
The patch I attached fixes this problem, and I'd appreciate a review before checking it in.
thanks,
alex
Re: need review on ajax change
Posted by Alex Dean <al...@crackpot.org>.
Thanks for taking a look!
On Feb 14, 2011, at 4:32 AM, Gary Tully wrote:
> patch looks good.
>
> On 13 February 2011 03:17, Alex Dean <al...@crackpot.org> wrote:
>
>> I attached a patch to fix https://issues.apache.org/jira/browse/AMQ-3123.
>>
>> If a continuation is not available when AjaxListener receives a message, it
>> buffers the message in a linked list for later delivery.
>> (MessageListenerServlet checks for any messages buffered in this way.) The
>> problem is that AjaxListener isn't currently maintaining the
>> message<->consumer association, so some messages get associated with the
>> wrong callback function when they're sent back to the web browser.
>>
>> The patch I attached fixes this problem, and I'd appreciate a review before
>> checking it in.
>>
>> thanks,
>> alex
>
>
>
>
> --
> http://blog.garytully.com
> http://fusesource.com
Re: need review on ajax change
Posted by Gary Tully <ga...@gmail.com>.
patch looks good.
On 13 February 2011 03:17, Alex Dean <al...@crackpot.org> wrote:
> I attached a patch to fix https://issues.apache.org/jira/browse/AMQ-3123.
>
> If a continuation is not available when AjaxListener receives a message, it
> buffers the message in a linked list for later delivery.
> (MessageListenerServlet checks for any messages buffered in this way.) The
> problem is that AjaxListener isn't currently maintaining the
> message<->consumer association, so some messages get associated with the
> wrong callback function when they're sent back to the web browser.
>
> The patch I attached fixes this problem, and I'd appreciate a review before
> checking it in.
>
> thanks,
> alex
--
http://blog.garytully.com
http://fusesource.com