[GitHub] [arrow] icexelloss commented on a diff in pull request #35874: GH-35838: [C++] Backpressure broken in asof join node

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1213516786


##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -668,13 +668,13 @@ class InputState {
 
   static Result<std::unique_ptr<InputState>> Make(
       size_t index, TolType tolerance, bool must_hash, bool may_rehash,
-      KeyHasher* key_hasher, AsofJoinNode* node, ExecNode* output,
+      KeyHasher* key_hasher, AsofJoinNode* node, ExecNode* input,

Review Comment:
   This still looking confusing:
   
   (1) BackpressureController takes `ExecNode* node, ExecNode* output` and this one nows takes `AsofJoinNode* node, ExecNode* input` which is inconsistent
   
   (2) InputState::Make uses to take inputs[i] but now it takes "node" which is the AsofJoinNode
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org