You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by mitchell852 <gi...@git.apache.org> on 2017/03/23 03:14:08 UTC
[GitHub] incubator-trafficcontrol pull request #400: tenant api - fixes boolean activ...
GitHub user mitchell852 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/400
tenant api - fixes boolean active flag on update and create
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitchell852/incubator-trafficcontrol fix-tenant-active
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/400.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #400
----
commit 48c4fcf3e7f8716ca1bee844b7467c36a5be1169
Author: Jeremy Mitchell <mi...@gmail.com>
Date: 2017-03-23T03:12:53Z
no boolean casting needed in this scenario. don't really know why.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #400: tenant api - fixes boolean active flag ...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/400
so check it out. you have to "cast" the booleans in index and show methods but not in create / update...
I don't know why to be honest...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #400: tenant api - fixes boolean active flag ...
Posted by nir-sopher <gi...@git.apache.org>.
Github user nir-sopher commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/400
Can the reason for the "no need of casting" be that the field is a Boolean in the DB? Maybe it is a change in behavior when moving to postgres?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #400: tenant api - fixes boolean activ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---