You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/21 17:02:55 UTC
[GitHub] [tinkerpop] jroimartin opened a new pull request, #1724: gremlin-go: improve docker-compose compatibility, fix run.sh command line parsing
jroimartin opened a new pull request, #1724:
URL: https://github.com/apache/tinkerpop/pull/1724
The current `docker-compose.yml` file is not compatible with the docker-compose version packaged by some widely used Linux distributions. For instance, Debian bullseye (current stable) [packages docker-compose 1.25.0](https://packages.debian.org/bullseye/docker-compose).
docker-compose 1.25.0 [supports up to compose file format 3.7](https://github.com/docker/compose/releases/tag/1.25.0) and requires the version to be explicitly set in the `docker-compose.yml` file.
By setting the version of the `docker-compose.yml` file to 3.7 we support docker-compose 1.22.0+ and the only required change is adding the "version" field. Also, [version 3 has not been deprecated](https://docs.docker.com/compose/compose-file/compose-versioning/).
Finally, `run.sh` accepts a gremlin-server version as argument, however it is not used when running tests. This PR also fixes this.
I have tested this PR both with docker-compose 1.25.0 and 2.6.0 (latest docker-ce version).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1724: gremlin-go: improve docker-compose compatibility, fix run.sh command line parsing
Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1724:
URL: https://github.com/apache/tinkerpop/pull/1724#issuecomment-1174020430
> @xiazcy thanks for the review! Is there anything I can do to help moving this forward?
Thanks @jroimartin, we are good on the code changes. We'll try to get this moving ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1724: gremlin-go: improve docker-compose compatibility, fix run.sh command line parsing
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1724:
URL: https://github.com/apache/tinkerpop/pull/1724#issuecomment-1163455345
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1724](https://codecov.io/gh/apache/tinkerpop/pull/1724?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6df733) into [3.5-dev](https://codecov.io/gh/apache/tinkerpop/commit/0a572133aab44c3f9d5cc3b6cb463950a21937e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a57213) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #1724 +/- ##
===========================================
- Coverage 63.27% 63.18% -0.09%
===========================================
Files 23 23
Lines 3553 3553
===========================================
- Hits 2248 2245 -3
- Misses 1131 1133 +2
- Partials 174 175 +1
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [gremlin-go/driver/gorillaTransporter.go](https://codecov.io/gh/apache/tinkerpop/pull/1724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZ29yaWxsYVRyYW5zcG9ydGVyLmdv) | `61.81% <0.00%> (-2.73%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1724?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1724?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0a57213...e6df733](https://codecov.io/gh/apache/tinkerpop/pull/1724?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] bechbd merged pull request #1724: gremlin-go: improve docker-compose compatibility, fix run.sh command line parsing
Posted by GitBox <gi...@apache.org>.
bechbd merged PR #1724:
URL: https://github.com/apache/tinkerpop/pull/1724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org