[jira] [Commented] (ACCUMULO-2532) FileUtil expects instance.dfs.dir in tmpDir path

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947241#comment-13947241 ] 

Josh Elser commented on ACCUMULO-2532:
--------------------------------------

[~ecn], something else I noticed while reading through this code:

{code:title=FileUtil.java:97-99}
      // try to reserve the tmp dir
      if (!fs.createNewFile(new Path(result, "__reserve")))
        result = null;
{code}

It looks like this {{__reserve}} file is never used anywhere else. Do you recall what the intent of making it was?

> FileUtil expects instance.dfs.dir in tmpDir path
> ------------------------------------------------
>
>                 Key: ACCUMULO-2532
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2532
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: master, tserver
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 1.6.0
>
>
> FileUtil#cleanupIndexOp(AccumuloConfiguration, Path, VolumeManager, ArrayList) checks that the temporary directory Path it was given ends with the value of instance.dfs.dir and "/tmp".
> instance.dfs.dir is no longer appended to each volume, so this check is likely wrong and result in tmp directories not being cleaned up properly.
> This also necessitates a unit test to prevent from happening again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)