You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/01 04:25:14 UTC
[GitHub] [superset] pkdotson opened a new pull request #13906: fix(listview): update listview feature flag
pkdotson opened a new pull request #13906:
URL: https://github.com/apache/superset/pull/13906
### SUMMARY
This pr addresses issue when feature flag THUMBNAILS is turned off it would leave LISTVIEWS_DEFAULT_CARD_VIEW true. This will check if thumbnails is enable and set the list view accordingly.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/17326228/113243225-78bef780-9267-11eb-8812-dcfc973da27d.mov
### TEST PLAN
If THUMBNAILS is false it when user goes to listviews for charts and dashboards it should default to the listview layout instead of cardview.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **increase** coverage by `0.22%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head 8e830f4. Consider uploading reports for the commit 8e830f4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
+ Coverage 77.53% 77.75% +0.22%
==========================================
Files 935 935
Lines 47319 47318 -1
Branches 5907 5907
==========================================
+ Hits 36689 36793 +104
+ Misses 10486 10382 -104
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.26% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `80.57% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `80.27% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `81.11% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `80.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...8e830f4](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head ee21193. Consider uploading reports for the commit ee21193 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 77.53% 77.47% -0.07%
==========================================
Files 935 935
Lines 47319 47290 -29
Branches 5907 5907
==========================================
- Hits 36689 36637 -52
- Misses 10486 10510 +24
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.58% <100.00%> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.58% <100.00%> (-0.53%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...ee21193](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head ee21193. Consider uploading reports for the commit ee21193 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 77.53% 77.50% -0.03%
==========================================
Files 935 935
Lines 47319 47318 -1
Branches 5907 5907
==========================================
- Hits 36689 36675 -14
- Misses 10486 10500 +14
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.64% <100.00%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...ee21193](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **increase** coverage by `0.14%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head ee21193. Consider uploading reports for the commit ee21193 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
+ Coverage 77.53% 77.68% +0.14%
==========================================
Files 935 935
Lines 47319 47318 -1
Branches 5907 5907
==========================================
+ Hits 36689 36759 +70
+ Misses 10486 10416 -70
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.26% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `80.57% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <100.00%> (-0.13%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...ee21193](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 79.38% -0.02%
==========================================
Files 938 938
Lines 47541 47539 -2
Branches 5940 5940
==========================================
- Hits 37749 37739 -10
- Misses 9666 9674 +8
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (ø)` | |
| hive | `80.49% <ø> (+<0.01%)` | :arrow_up: |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `80.51% <ø> (+0.01%)` | :arrow_up: |
| python | `81.32% <ø> (-0.04%)` | :arrow_down: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `1.64%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 77.75% -1.65%
==========================================
Files 938 935 -3
Lines 47541 47318 -223
Branches 5940 5907 -33
==========================================
- Hits 37749 36793 -956
- Misses 9666 10382 +716
- Partials 126 143 +17
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.26% <100.00%> (-0.23%)` | :arrow_down: |
| mysql | `80.57% <100.00%> (-0.20%)` | :arrow_down: |
| postgres | `80.60% <100.00%> (-0.19%)` | :arrow_down: |
| presto | `80.27% <100.00%> (-0.24%)` | :arrow_down: |
| python | `81.11% <100.00%> (-0.25%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.78% <100.00%> (-0.20%)` | :arrow_down: |
| [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | `0.00% <0.00%> (-91.67%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-90.00%)` | :arrow_down: |
| [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | `0.00% <0.00%> (-86.67%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | `2.05% <0.00%> (-85.62%)` | :arrow_down: |
| [...board/util/getSelectedChartIdForFilterScopeTree.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldFNlbGVjdGVkQ2hhcnRJZEZvckZpbHRlclNjb3BlVHJlZS5qcw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlTm9kZXNUcmVlLmpz) | `2.38% <0.00%> (-78.58%)` | :arrow_down: |
| [superset/tasks/scheduler.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVyLnB5) | `0.00% <0.00%> (-76.93%)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 79.10% -0.30%
==========================================
Files 938 938
Lines 47541 47512 -29
Branches 5940 5940
==========================================
- Hits 37749 37584 -165
- Misses 9666 9802 +136
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.79% <ø> (-0.56%)` | :arrow_down: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.32% <0.00%> (-6.46%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r607315016
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
This feature flag was added as per @bkyryliuk so that it can default to a certain view, regardless if thumbnails are enabled or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 938 938
Lines 47541 47539 -2
Branches 5940 5940
=======================================
+ Hits 37749 37750 +1
+ Misses 9666 9663 -3
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (ø)` | |
| hive | `80.49% <ø> (+<0.01%)` | :arrow_up: |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `80.79% <ø> (+<0.01%)` | :arrow_up: |
| presto | `80.51% <ø> (+0.01%)` | :arrow_up: |
| python | `81.36% <ø> (+0.01%)` | :arrow_up: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 79.10% -0.30%
==========================================
Files 938 938
Lines 47541 47512 -29
Branches 5940 5940
==========================================
- Hits 37749 37584 -165
- Misses 9666 9802 +136
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (ø)` | |
| hive | `?` | |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.79% <ø> (-0.56%)` | :arrow_down: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.42% <0.00%> (-16.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-7.75%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `90.32% <0.00%> (-6.46%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <0.00%> (-1.69%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.99% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **increase** coverage by `0.22%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head ee21193. Consider uploading reports for the commit ee21193 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
+ Coverage 77.53% 77.75% +0.22%
==========================================
Files 935 935
Lines 47319 47318 -1
Branches 5907 5907
==========================================
+ Hits 36689 36793 +104
+ Misses 10486 10382 -104
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `80.26% <100.00%> (+<0.01%)` | :arrow_up: |
| mysql | `80.57% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `80.27% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `81.11% <100.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `80.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...ee21193](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head ee21193. Consider uploading reports for the commit ee21193 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 77.53% 77.52% -0.01%
==========================================
Files 935 935
Lines 47319 47318 -1
Branches 5907 5907
==========================================
- Hits 36689 36685 -4
- Misses 10486 10490 +4
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.57% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <100.00%> (-0.42%)` | :arrow_down: |
| sqlite | `80.16% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...ee21193](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r608884506
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
@pkdotson @nytai @bkyryliuk @junlincc It sounds like there's an easy solution, then - two completely separate feature flags:
* `THUMBNAILS` - turns thumbnail generation on, and shows the thumbnails (default or otherwise) in the cards. Set to `False` by default.
* `LISTVIEWS_DEFAULT_CARD_VIEW` - set separately, with no dependence/reliance with the `THUMBNAILS` - its only purpose in life is to set the status of the card/list toggle. Set to `False` by default.
If that works for everyone, this PR can simply get rid of this whole chunk, and let the flags live their own separate lives:
```
# Set the default view to card/grid view if thumbnail support is enabled.
# Setting LISTVIEWS_DEFAULT_CARD_VIEW to False will force the default view to
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (a495391) into [master](https://codecov.io/gh/apache/superset/commit/11dd2493b3427674bff8e3a7233bbfebff60bdc8?el=desc) (11dd249) will **decrease** coverage by `0.05%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head a495391 differs from pull request most recent head ee21193. Consider uploading reports for the commit ee21193 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 77.53% 77.48% -0.06%
==========================================
Files 935 935
Lines 47319 47318 -1
Branches 5907 5907
==========================================
- Hits 36689 36664 -25
- Misses 10486 10511 +25
+ Partials 144 143 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.60% <100.00%> (-0.51%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `92.70% <ø> (+1.04%)` | :arrow_up: |
| [...et-frontend/src/components/TableSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci9pbmRleC50c3g=) | `84.92% <ø> (ø)` | |
| [...src/dashboard/components/dnd/handleScroll/index.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwvaW5kZXgudHM=) | `73.33% <ø> (ø)` | |
| [...re/components/controls/DatasourceControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC9pbmRleC5qc3g=) | `86.84% <ø> (ø)` | |
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `35.00% <ø> (ø)` | |
| [...trols/DndColumnSelectControl/components/Option.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2NvbXBvbmVudHMvT3B0aW9uLnRzeA==) | `50.00% <ø> (ø)` | |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <ø> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | `74.83% <ø> (ø)` | |
| [...terControl/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTcWxUYWJDb250ZW50LmpzeA==) | `63.33% <ø> (ø)` | |
| [...nents/controls/FilterControl/AdhocFilterOption.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [11dd249...ee21193](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r608884506
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
@pkdotson @nytai @bkyryliuk @junlincc It sounds like there's an easy solution, then - two completely separate feature flags:
* `THUMBNAILS` - turns thumbnail generation on, and shows the thumbnails (default or generated) in the cards. Set to `False` by default.
* `LISTVIEWS_DEFAULT_CARD_VIEW` - set separately, with no dependence/reliance with the `THUMBNAILS` - its only purpose in life is to set the status of the card/list toggle. Set to `False` by default.
If that works for everyone, this PR can simply get rid of this whole chunk, and let the flags live their own separate lives:
```
# Set the default view to card/grid view if thumbnail support is enabled.
# Setting LISTVIEWS_DEFAULT_CARD_VIEW to False will force the default view to
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] bkyryliuk commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r607986953
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
yeah - this is quite needed. Setting up thumbnails is quite complex and has some security implications. Having this feature flag helps to default to the list view for the superset users when thumbnails are not enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r608884506
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
@pkdotson @nytai @bkyryliuk @junlincc It sounds like there's an easy solution, then - two completely separate feature flags:
* `THUMBNAILS` - turns thumbnail generation on, and shows the thumbnails (default or generated) in the cards. Set to `False` by default.
* `LISTVIEWS_DEFAULT_CARD_VIEW` - set separately, with no dependence/reliance with the `THUMBNAILS` - its only purpose in life is to set the status of the card/list toggle to show cards on load. Set to `False` by default.
If that works for everyone, this PR can simply get rid of this whole chunk, and let the flags live their own separate lives:
```
# Set the default view to card/grid view if thumbnail support is enabled.
# Setting LISTVIEWS_DEFAULT_CARD_VIEW to False will force the default view to
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 79.29% -0.11%
==========================================
Files 938 938
Lines 47541 47539 -2
Branches 5940 5940
==========================================
- Hits 37749 37698 -51
- Misses 9666 9715 +49
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (ø)` | |
| hive | `80.49% <ø> (+<0.01%)` | :arrow_up: |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `81.16% <ø> (-0.20%)` | :arrow_down: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `84.10% <0.00%> (-5.44%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.34% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.10% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13906:
URL: https://github.com/apache/superset/pull/13906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 79.38% -0.02%
==========================================
Files 938 938
Lines 47541 47539 -2
Branches 5940 5940
==========================================
- Hits 37749 37739 -10
- Misses 9666 9674 +8
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (ø)` | |
| hive | `80.49% <ø> (+<0.01%)` | :arrow_up: |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `80.51% <ø> (+0.01%)` | :arrow_up: |
| python | `81.32% <ø> (-0.04%)` | :arrow_down: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 938 938
Lines 47541 47539 -2
Branches 5940 5940
=======================================
+ Hits 37749 37750 +1
+ Misses 9666 9663 -3
Partials 126 126
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (ø)` | |
| hive | `80.49% <ø> (+<0.01%)` | :arrow_up: |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `80.77% <ø> (-0.02%)` | :arrow_down: |
| presto | `80.51% <ø> (+0.01%)` | :arrow_up: |
| python | `81.36% <ø> (+0.01%)` | :arrow_up: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `89.95% <0.00%> (+0.41%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13906:
URL: https://github.com/apache/superset/pull/13906#issuecomment-811636221
# [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=h1) Report
> Merging [#13906](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=desc) (7c17b12) into [master](https://codecov.io/gh/apache/superset/commit/667eb83e33e8f95b70a146a755ae4f672d27d9d8?el=desc) (667eb83) will **decrease** coverage by `1.52%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7c17b12 differs from pull request most recent head 824b62b. Consider uploading reports for the commit 824b62b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13906 +/- ##
==========================================
- Coverage 79.40% 77.87% -1.53%
==========================================
Files 938 938
Lines 47541 47511 -30
Branches 5940 5940
==========================================
- Hits 37749 36999 -750
- Misses 9666 10356 +690
- Partials 126 156 +30
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.01% <ø> (-8.05%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.76% <ø> (+<0.01%)` | :arrow_up: |
| postgres | `?` | |
| presto | `?` | |
| python | `80.79% <ø> (-0.56%)` | :arrow_down: |
| sqlite | `80.39% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.25% <ø> (+0.28%)` | :arrow_up: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| ... and [80 more](https://codecov.io/gh/apache/superset/pull/13906/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=footer). Last update [667eb83...824b62b](https://codecov.io/gh/apache/superset/pull/13906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r607312552
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
I think we actually don't need it. As we can do the conditional check using the thumbnails feature flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #13906: fix(listview): update listview feature flag
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #13906:
URL: https://github.com/apache/superset/pull/13906#discussion_r605615780
##########
File path: superset/config.py
##########
@@ -366,6 +366,8 @@ def _try_json_readsha( # pylint: disable=unused-argument
# always be the table layout
if DEFAULT_FEATURE_FLAGS["THUMBNAILS"]:
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = True
+else:
+ DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = False
Review comment:
nit: this is equal to
```
DEFAULT_FEATURE_FLAGS["LISTVIEWS_DEFAULT_CARD_VIEW"] = DEFAULT_FEATURE_FLAGS["THUMBNAILS"]
```
Does it still make sense to have this feature flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org