You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/07/10 06:59:52 UTC
[GitHub] [airflow] uranusjr opened a new pull request, #32478: Allow class name to have leading underscores
uranusjr opened a new pull request, #32478:
URL: https://github.com/apache/airflow/pull/32478
#32475 was not enough to fix main 🥲
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Adaverse commented on a diff in pull request #32478: Allow class name to have leading underscores
Posted by "Adaverse (via GitHub)" <gi...@apache.org>.
Adaverse commented on code in PR #32478:
URL: https://github.com/apache/airflow/pull/32478#discussion_r1257830021
##########
scripts/in_container/verify_providers.py:
##########
@@ -567,7 +568,7 @@ def check_if_classes_are_properly_named(
if not is_camel_case_with_acronyms(class_name):
console.print(
f"[red]The class {class_full_name} is wrongly named. The "
- f"class name should be CamelCaseWithACRONYMS ![/]"
+ f"class name should be CamelCaseWithACRONYMS[/]"
Review Comment:
```suggestion
f"class name should be CamelCaseWithACRONYMS "
"with optionally single underscore allowed at beginning[/]"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #32478: Allow class name to have leading underscores
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #32478:
URL: https://github.com/apache/airflow/pull/32478#issuecomment-1628820309
Failures are unrelated and should be fixed by #32489.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #32478: Allow class name to have leading underscores
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #32478:
URL: https://github.com/apache/airflow/pull/32478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org