You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by "Liya Fan (Jira)" <ji...@apache.org> on 2019/08/28 10:30:00 UTC
[jira] [Created] (ARROW-6374) [Java] Refactor the code for
TimeXXVectors
Liya Fan created ARROW-6374:
-------------------------------
Summary: [Java] Refactor the code for TimeXXVectors
Key: ARROW-6374
URL: https://issues.apache.org/jira/browse/ARROW-6374
Project: Apache Arrow
Issue Type: Improvement
Components: Java
Reporter: Liya Fan
Assignee: Liya Fan
This is based on the discussion in [https://lists.apache.org/thread.html/836d3b87ccb6e65e9edf0f220829a29edfa394fc2cd1e0866007d86e@%3Cdev.arrow.apache.org%3E.|https://lists.apache.org/thread.html/836d3b87ccb6e65e9edf0f220829a29edfa394fc2cd1e0866007d86e@%3Cdev.arrow.apache.org%3E,]
The internals of TimeXXVectors are simply IntVector or BigIntVector. There are duplicated code for setting/getting int/long.
We want to refactor the code by:
# push get/set methods into the base class BaseFixedWidthVector, and make them protected.
# The APIs in TimeXXVectors references the methods in the base class.
Note that this issue not just reduce redundant code, it also centralizes the logics for getting/setting int/long, making them easy to maintain and change.
If it looks good, later we will make other integer based vectors rely on the base class implementations.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)