You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by sp...@apache.org on 2010/08/13 17:03:18 UTC

svn commit: r985227 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: afp/goca/ afp/svg/ afp/util/ fo/flow/table/ fo/properties/ fonts/autodetect/ layoutmgr/inline/ pdf/ render/afp/ render/bitmap/ render/pdf/ render/rtf/ render/rtf/rtflib/rtfdoc/ sv...

Author: spepping
Date: Fri Aug 13 15:03:17 2010
New Revision: 985227

URL: http://svn.apache.org/viewvc?rev=985227&view=rev
Log:
Removed a bunch of javadoc warnings in addition to patch 49733

Modified:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsChainedSegment.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/svg/AFPTextHandler.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/util/DTDEntityResolver.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/table/TableRow.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/CompoundPropertyMaker.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/autodetect/FontInfoFinder.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFEncryptionJCE.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFNull.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFToUnicodeCMap.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRendererConfigurator.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TextAttributesConverter.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfBookmark.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfExternalGraphic.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfFootnote.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfTableCell.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphicsDevice.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFTextPainter.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/FileCompare.java
    xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/Fop.java

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsChainedSegment.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsChainedSegment.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsChainedSegment.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/goca/GraphicsChainedSegment.java Fri Aug 13 15:03:17 2010
@@ -73,7 +73,6 @@ public final class GraphicsChainedSegmen
         return NAME_LENGTH;
     }
 
-    /** {@inheritDoc} */
     byte getOrderCode() {
         return 0x70;
     }

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/svg/AFPTextHandler.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/svg/AFPTextHandler.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/svg/AFPTextHandler.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/svg/AFPTextHandler.java Fri Aug 13 15:03:17 2010
@@ -73,7 +73,6 @@ public class AFPTextHandler implements F
      * Registers a page font
      *
      * @param internalFontName the internal font name
-     * @param internalFontName the internal font name
      * @param fontSize the font size
      * @return a font reference
      */

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/util/DTDEntityResolver.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/util/DTDEntityResolver.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/util/DTDEntityResolver.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/util/DTDEntityResolver.java Fri Aug 13 15:03:17 2010
@@ -98,7 +98,7 @@ public class DTDEntityResolver implement
 
     /**
      * Returns the URL of a resource on the classpath
-     * @param resourceName the path to the resource relative to the root of the
+     * @param resourcePath the path to the resource relative to the root of the
      * classpath.
      * @return the URL of the required resource
      * @throws FontRuntimeException if the resource could not be found.

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/table/TableRow.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/table/TableRow.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/table/TableRow.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/table/TableRow.java Fri Aug 13 15:03:17 2010
@@ -144,7 +144,6 @@ public class TableRow extends TableCellC
         return (TablePart) parent;
     }
 
-    /** {@inheritDoc} */
     boolean isTableRow() {
         return true;
     }

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/CompoundPropertyMaker.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/CompoundPropertyMaker.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/CompoundPropertyMaker.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/properties/CompoundPropertyMaker.java Fri Aug 13 15:03:17 2010
@@ -101,7 +101,7 @@ public class CompoundPropertyMaker exten
      * Calculate the real value of a subproperty by unmasking and shifting
      * the value into the range [0 - (COMPOUND_COUNT-1)].
      * The value is used as index into the subproperties array.
-     * @param propId the property id of the sub property.
+     * @param subpropertyId the property id of the sub property.
      * @return the array index.
      */
     private int getSubpropIndex(int subpropertyId) {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/autodetect/FontInfoFinder.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/autodetect/FontInfoFinder.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/autodetect/FontInfoFinder.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/autodetect/FontInfoFinder.java Fri Aug 13 15:03:17 2010
@@ -70,7 +70,7 @@ public class FontInfoFinder {
      * It seems to be fairly accurate but will probably require some tweaking over time
      *
      * @param customFont CustomFont
-     * @param triplet Collection that will take the generated triplets
+     * @param triplets Collection that will take the generated triplets
      */
     private void generateTripletsFromFont(CustomFont customFont, Collection triplets) {
         if (log.isTraceEnabled()) {
@@ -138,7 +138,7 @@ public class FontInfoFinder {
      * @param fontUrl the font URL
      * @param customFont the custom font
      * @param fontCache font cache (may be null)
-     * @return
+     * @return FontInfo from the given custom font
      */
     private EmbedFontInfo getFontInfoFromCustomFont(
             URL fontUrl, CustomFont customFont, FontCache fontCache) {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AbstractPageNumberCitationLayoutManager.java Fri Aug 13 15:03:17 2010
@@ -99,10 +99,9 @@ public abstract class AbstractPageNumber
     }
 
     /**
-     * If id can be resolved then simply return a word, otherwise
+     * If id can be resolved then simply return a text area, otherwise
      * return a resolvable area
      *
-     * @param parentLM  the parent LayoutManager
      * @return a corresponding InlineArea
      */
     private InlineArea getPageNumberCitationInlineArea() {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/AlignmentContext.java Fri Aug 13 15:03:17 2010
@@ -307,7 +307,6 @@ public class AlignmentContext implements
      * Calculates the baseline shift value based on the baseline-shift
      * property value.
      * @param baselineShift the baseline shift property value
-     * @return the computed baseline shift value
      */
     private void setBaselineShift(Length baselineShift) {
         baselineShiftValue = 0;

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFEncryptionJCE.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFEncryptionJCE.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFEncryptionJCE.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFEncryptionJCE.java Fri Aug 13 15:03:17 2010
@@ -80,26 +80,6 @@ public class PDFEncryptionJCE extends PD
         }
 
         /**
-         * Encode the given data with the filter
-         * @param data The data to be encrypted
-         * @return The encrypted data
-         */
-        public byte[] encode(byte[] data) {
-            return encryption.encryptData(data, number, generation);
-        }
-
-        /**
-         * {@inheritDoc}
-         */
-        public void encode(InputStream in, OutputStream out, int length)
-                                                        throws IOException {
-            byte[] buffer = new byte[length];
-            in.read(buffer);
-            buffer = encode(buffer);
-            out.write(buffer);
-        }
-
-        /**
          * {@inheritDoc}
          */
         public OutputStream applyFilter(OutputStream out) throws IOException {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFNull.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFNull.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFNull.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFNull.java Fri Aug 13 15:03:17 2010
@@ -33,7 +33,6 @@ public final class PDFNull implements PD
 
     /**
      * Creates a new PDF name object.
-     * @param name the name value
      */
     private PDFNull() {
     }

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFToUnicodeCMap.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFToUnicodeCMap.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFToUnicodeCMap.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFToUnicodeCMap.java Fri Aug 13 15:03:17 2010
@@ -79,7 +79,6 @@ public class PDFToUnicodeCMap extends PD
 
         /**
          * Writes the CMap to a Writer.
-         * @param writer the writer
          * @throws IOException if an I/O error occurs
          */
         public void writeCMap() throws IOException {
@@ -94,7 +93,6 @@ public class PDFToUnicodeCMap extends PD
 
         /**
          * Writes the character mappings for this font.
-         * @param p StingBuffer to write to
          */
         protected void writeBFEntries() throws IOException {
             if (unicodeCharMap != null) {
@@ -106,7 +104,6 @@ public class PDFToUnicodeCMap extends PD
         /**
          * Writes the entries for single characters of a base font (only characters which cannot be
          * expressed as part of a character range).
-         * @param p StringBuffer to write to
          * @param charArray all the characters to map
          * @throws IOException
          */
@@ -147,7 +144,6 @@ public class PDFToUnicodeCMap extends PD
 
         /**
          * Writes the entries for character ranges for a base font.
-         * @param p StringBuffer to write to
          * @param charArray all the characters to map
          * @throws IOException
          */

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRendererConfigurator.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRendererConfigurator.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRendererConfigurator.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/afp/AFPRendererConfigurator.java Fri Aug 13 15:03:17 2010
@@ -149,7 +149,7 @@ public class AFPRendererConfigurator ext
      * @param encoding character encoding e.g. 'Cp500', 'UnicodeBigUnmarked'
      * @param accessor
      * @param afpFontCfg
-     * @return
+     * @return the created AFPFont
      * @throws ConfigurationException
      */
     private AFPFont fontFromType(String type, String codepage, String encoding,

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/bitmap/PNGRenderer_onthefly.java Fri Aug 13 15:03:17 2010
@@ -125,7 +125,7 @@ public class PNGRenderer_onthefly extend
 
     /**
      * Builds the OutputStream corresponding to this page
-     * @param 0-based pageNumber
+     * @param pageNumber the 0-based page number
      * @return the corresponding OutputStream
      */
     private OutputStream getCurrentOutputStream(int pageNumber) {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFPainter.java Fri Aug 13 15:03:17 2010
@@ -162,10 +162,7 @@ public class PDFPainter extends Abstract
 
     /**
      * Places a previously registered image at a certain place on the page.
-     * @param x X coordinate
-     * @param y Y coordinate
-     * @param w width for image
-     * @param h height for image
+     * @param rect the rectangle for the image
      * @param xobj the image XObject
      */
     private void placeImage(Rectangle rect, PDFXObject xobj) {
@@ -179,10 +176,7 @@ public class PDFPainter extends Abstract
     }
     /**
      * Places a previously registered image at a certain place on the page - Accessibility version
-     * @param x X coordinate
-     * @param y Y coordinate
-     * @param w width for image
-     * @param h height for image
+     * @param rect the rectangle for the image
      * @param xobj the image XObject
      */
     private void placeImageAccess(Rectangle rect, PDFXObject xobj) {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java Fri Aug 13 15:03:17 2010
@@ -65,11 +65,8 @@ public final class TableAttributesConver
     /**
      * Converts table-only attributes to rtf attributes.
      *
-     * @param attrs Given attributes
-     * @param defaultAttributes Default rtf attributes
-     *
+     * @param fobj the table for which the attributes are converted
      * @return All valid rtf attributes together
-     *
      * @throws ConverterException On convertion error
      */
     static RtfAttributes convertTableAttributes(Table fobj)
@@ -83,11 +80,8 @@ public final class TableAttributesConver
     /**
      * Converts table-only attributes to rtf attributes.
      *
-     * @param attrs Given attributes
-     * @param defaultAttributes Default rtf attributes
-     *
+     * @param part the table part for which the attributes are converted
      * @return All valid rtf attributes together
-     *
      * @throws ConverterException On convertion error
      */
     static RtfAttributes convertTablePartAttributes(TablePart part)
@@ -226,8 +220,6 @@ public final class TableAttributesConver
      * Converts table and row attributes to rtf attributes.
      *
      * @param fobj FObj to be converted
-     * @param defaultAttributes Default rtf attributes
-     *
      * @return All valid rtf attributes together
      * @throws ConverterException On converion error
      */

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TextAttributesConverter.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TextAttributesConverter.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TextAttributesConverter.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/TextAttributesConverter.java Fri Aug 13 15:03:17 2010
@@ -68,7 +68,7 @@ final class TextAttributesConverter {
 
     /**
      * Converts all known text FO properties to RtfAttributes
-     * @param props list of FO properites, which are to be converted
+     * @param fobj the FO for which the attributes are to be converted
      */
     public static RtfAttributes convertAttributes(Block fobj)
                 throws FOPException {
@@ -86,7 +86,7 @@ final class TextAttributesConverter {
 
     /**
      * Converts all known text FO properties to RtfAttributes
-     * @param props list of FO properites, which are to be converted
+     * @param fobj FObj whose properties are to be converted
      */
     public static RtfAttributes convertBlockContainerAttributes(BlockContainer fobj)
                 throws FOPException {
@@ -442,7 +442,7 @@ final class TextAttributesConverter {
     /**
      * Reads background-color from bl and writes it to rtfAttr.
      *
-     * @param bl the Block object the properties are read from
+     * @param bph the CommonBorderPaddingBackground from which the properties are read
      * @param rtfAttr the RtfAttributes object the attributes are written to
      */
     private static void attrBackgroundColor(CommonBorderPaddingBackground bpb,

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfBookmark.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfBookmark.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfBookmark.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfBookmark.java Fri Aug 13 15:03:17 2010
@@ -59,8 +59,8 @@ public class RtfBookmark extends RtfElem
      * @param writer a <code>Writer</code> value
      * @param bookmark Name of the bookmark
      */
-    RtfBookmark (RtfContainer parent, Writer w, String bookmark) throws IOException {
-        super (parent, w);
+    RtfBookmark (RtfContainer parent, Writer writer, String bookmark) throws IOException {
+        super (parent, writer);
 
         int now = bookmark.length ();
 

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfExternalGraphic.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfExternalGraphic.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfExternalGraphic.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfExternalGraphic.java Fri Aug 13 15:03:17 2010
@@ -87,8 +87,8 @@ public class RtfExternalGraphic extends 
         /**
          * Convert image data if necessary - for example when format is not supported by rtf.
          *
+         * @param format Format type
          * @param data Image
-         * @param type Format type
          */
         public FormatBase convert(FormatBase format, byte[] data) {
             return format;

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfFootnote.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfFootnote.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfFootnote.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfFootnote.java Fri Aug 13 15:03:17 2010
@@ -38,13 +38,22 @@ public class RtfFootnote extends RtfCont
     RtfList list = null;
     boolean bBody = false;
 
-    /** Create an RTF list item as a child of given container with default attributes */
+    /**
+     * Create an RTF list item as a child of given container with default attributes.
+     * @param parent a container
+     * @param w a writer
+     * @throws IOException if not caught
+     */
     RtfFootnote(RtfContainer parent, Writer w) throws IOException {
         super(parent, w);
         textrunInline = new RtfTextrun(this, writer, null);
         body = new RtfContainer(this, writer);
     }
 
+    /**
+     * @return a text run
+     * @throws IOException if not caught
+     */
     public RtfTextrun getTextrun() throws IOException {
         if (bBody) {
             RtfTextrun textrun = RtfTextrun.getTextrun(body, writer, null);

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfTableCell.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfTableCell.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfTableCell.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/render/rtf/rtflib/rtfdoc/RtfTableCell.java Fri Aug 13 15:03:17 2010
@@ -181,8 +181,8 @@ public class RtfTableCell
     }
 
     /** used by RtfTableRow to write the <celldef> cell definition control words
-     *  @param widthOffset sum of the widths of preceeding cells in same row
-     *  @return widthOffset + width of this cell
+     *  @param offset sum of the widths of preceeding cells in same row
+     *  @return offset + width of this cell
      */
     int writeCellDef(int offset) throws IOException {
         /*

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphicsDevice.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphicsDevice.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphicsDevice.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFGraphicsDevice.java Fri Aug 13 15:03:17 2010
@@ -39,7 +39,7 @@ class PDFGraphicsDevice extends Graphics
     /**
      * Create a new PDF graphics device.
      *
-     * @param The gc we should reference
+     * @param gc The graphics configuration we should reference
      */
     PDFGraphicsDevice(PDFGraphicsConfiguration gc) {
         this.gc = gc;

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFTextPainter.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFTextPainter.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFTextPainter.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/svg/PDFTextPainter.java Fri Aug 13 15:03:17 2010
@@ -40,7 +40,7 @@ import org.apache.fop.fonts.FontInfo;
 import org.apache.fop.util.CharUtilities;
 
 /**
- * Renders the attributed character iterator of a {@link TextNode}.
+ * Renders the attributed character iterator of a {@link org.apache.batik.gvt.TextNode}.
  * This class draws the text directly into the PDFGraphics2D so that
  * the text is not drawn using shapes which makes the PDF files larger.
  * If the text is simple enough to draw then it sets the font and calls

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/FileCompare.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/FileCompare.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/FileCompare.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/FileCompare.java Fri Aug 13 15:03:17 2010
@@ -91,7 +91,9 @@ public class FileCompare {
 
     /**
      * Compare the contents of two files.
-     * @param true if files are same byte-by-byte, false otherwise
+     * @param file1 the first file to compare
+     * @param file2 the second file to compare
+     * @return true if files are same byte-by-byte, false otherwise
      */
     private static boolean compareBytes(File file1, File file2) throws IOException {
         BufferedInputStream file1Input =
@@ -116,7 +118,9 @@ public class FileCompare {
 
     /**
      * Does a file size compare of two files
-     * @param true if files are same length, false otherwise
+     * @param file1 the first file to compare
+     * @param file2 the second file to compare
+     * @return true if files are same length, false otherwise
      */
     private static boolean compareFileSize(File oldFile, File newFile) {
         if (oldFile.length() != newFile.length()) {

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/Fop.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/Fop.java?rev=985227&r1=985226&r2=985227&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/Fop.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/Fop.java Fri Aug 13 15:03:17 2010
@@ -489,9 +489,6 @@ class FOPTaskStarter {
         return new File(file.getParentFile(), name);
     }
 
-    /**
-     * {@inheritDoc}
-     */
     public void run() throws FOPException {
         //Set base directory
         if (task.getBasedir() != null) {



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org