You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Fox (JIRA)" <ji...@apache.org> on 2011/07/03 21:27:21 UTC
[jira] [Resolved] (TORQUE-111) Thrown RuntimeExceptions cause
database connections to remain open
[ https://issues.apache.org/jira/browse/TORQUE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox resolved TORQUE-111.
-------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Thomas Fox
Caching Exceptions is not pretty because the exception should be rethrown and the mewthod should still only throw a TorqueException. Using a try..finally block is more elegant.
> Thrown RuntimeExceptions cause database connections to remain open
> ------------------------------------------------------------------
>
> Key: TORQUE-111
> URL: https://issues.apache.org/jira/browse/TORQUE-111
> Project: Torque
> Issue Type: Bug
> Components: Runtime
> Affects Versions: 3.2, 3.3
> Reporter: Neil Weber
> Assignee: Thomas Fox
> Priority: Critical
> Fix For: 4.0
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> In the doSelect(), doDelete(), doInsert(), and doUpdate() methods in BasePeer a database connection is obtained, some work performed, and then, if successful, the work is committed and the database connection is closed. If a TorqueException is thrown while performing the work, the work is rolled back and the database connection is closed. If a RuntimeException is thrown while performing the work, the work is *not* rolled back and the database connection remains open.
> The fix is simple: catch Exception (or Throwable) instead of TorqueException. This will ensure that, no matter what the problem is, Torque ensures the database connection is closed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org