You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/12 23:47:16 UTC
[GitHub] [incubator-mxnet] MoisesHer opened a new pull request #19894: Use multi-tensor zeroing for resetting grads
MoisesHer opened a new pull request #19894:
URL: https://github.com/apache/incubator-mxnet/pull/19894
## Description ##
Use multi-tensor kernel strategy for resetting gradients.
Undo [https://github.com/apache/incubator-mxnet/pull/16716](https://github.com/apache/incubator-mxnet/pull/16716)
## Checklist ##
### Essentials ###
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage ([https://github.com/sxjscience/mxnet/blob/master/tests/python/unittest/test_numpy_gluon.py#L185](https://github.com/sxjscience/mxnet/blob/master/tests/python/unittest/test_numpy_gluon.py#L185))
- [x] Code is well-documented
### Changes ###
- [x] in zero_grad method, use ndarray.reset_arrays for resetting multiple arrays within same kernel
## Comments ##
Performance observed training BERT-large on single V100 GPU:
........................................................................**Throughput samples / s**
**BatchSize - BatchAccumulation............Pre-Change............This-PR (multi-tensor )............ Improvement(%)**
................4 - 2 .............................................. 29.82 ..........................36.24.............................................. 21.5
................4 - 4............................................... 36.89............................41.45..............................................12.3
................8 - 4............................................... 45.25............................48.41.............................................. 6.9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #19894: Use multi-tensor zeroing for resetting grads
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19894:
URL: https://github.com/apache/incubator-mxnet/pull/19894
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19894: Use multi-tensor zeroing for resetting grads
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19894:
URL: https://github.com/apache/incubator-mxnet/pull/19894#issuecomment-778516536
Hey @MoisesHer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, sanity, edge, miscellaneous, unix-cpu, centos-cpu, clang, windows-cpu, centos-gpu, windows-gpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org