You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vaibhav Gumashta <vg...@hortonworks.com> on 2014/11/13 23:42:26 UTC
Review Request 28007: HS2 & Metastore using SASL out of memory error
when curl sends a get request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28007/
-----------------------------------------------------------
Review request for hive, Navis Ryu and Thejas Nair.
Bugs: HIVE-6468
https://issues.apache.org/jira/browse/HIVE-6468
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-6468
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ea5aed8
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d1ef305
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 23ba79c
service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java afc1441
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 624ac6b
shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java d011c67
Diff: https://reviews.apache.org/r/28007/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 28007: HS2 & Metastore using SASL out of memory
error when curl sends a get request
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28007/#review61380
-----------------------------------------------------------
service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java
<https://reviews.apache.org/r/28007/#comment102952>
This statement is common for both types of factories. Move the factory creation to if-else and add call addServerDefinition just in one place ?
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
<https://reviews.apache.org/r/28007/#comment102953>
addServerDefinition statements here are also common and we can have it in just one place
shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
<https://reviews.apache.org/r/28007/#comment103170>
Can you add a comment saying that this anonymous subclass of TSaslServerTransport , where the recieveSaslMessage is replaced with one that also has additional check for the message size.
shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java
<https://reviews.apache.org/r/28007/#comment103163>
Can you also, add something like "The connection is possibly using a protocol other than thrift.".
- Thejas Nair
On Nov. 14, 2014, 12:32 a.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28007/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 12:32 a.m.)
>
>
> Review request for hive, Navis Ryu and Thejas Nair.
>
>
> Bugs: HIVE-6468
> https://issues.apache.org/jira/browse/HIVE-6468
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-6468
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ea5aed8
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d1ef305
> service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 23ba79c
> service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java afc1441
> shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 624ac6b
> shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java d011c67
>
> Diff: https://reviews.apache.org/r/28007/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 28007: HS2 & Metastore using SASL out of memory
error when curl sends a get request
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28007/#review64050
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Nov. 18, 2014, 9:51 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28007/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 9:51 p.m.)
>
>
> Review request for hive, Navis Ryu and Thejas Nair.
>
>
> Bugs: HIVE-6468
> https://issues.apache.org/jira/browse/HIVE-6468
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-6468
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ea5aed8
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d1ef305
> service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 23ba79c
> service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java afc1441
> shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 624ac6b
> shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java d011c67
>
> Diff: https://reviews.apache.org/r/28007/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>
Re: Review Request 28007: HS2 & Metastore using SASL out of memory
error when curl sends a get request
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28007/
-----------------------------------------------------------
(Updated Nov. 18, 2014, 9:51 p.m.)
Review request for hive, Navis Ryu and Thejas Nair.
Bugs: HIVE-6468
https://issues.apache.org/jira/browse/HIVE-6468
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-6468
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ea5aed8
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d1ef305
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 23ba79c
service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java afc1441
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 624ac6b
shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java d011c67
Diff: https://reviews.apache.org/r/28007/diff/
Testing
-------
Thanks,
Vaibhav Gumashta
Re: Review Request 28007: HS2 & Metastore using SASL out of memory
error when curl sends a get request
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28007/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 12:32 a.m.)
Review request for hive, Navis Ryu and Thejas Nair.
Changes
-------
Got rid of extra formatting that the previous patch added.
Bugs: HIVE-6468
https://issues.apache.org/jira/browse/HIVE-6468
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-6468
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ea5aed8
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java d1ef305
service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 23ba79c
service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java afc1441
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 624ac6b
shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java d011c67
Diff: https://reviews.apache.org/r/28007/diff/
Testing
-------
Thanks,
Vaibhav Gumashta